From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC5D5C742A1 for ; Fri, 12 Jul 2019 00:25:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C20DB208E4 for ; Fri, 12 Jul 2019 00:25:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="v29BE733" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730540AbfGLAZW (ORCPT ); Thu, 11 Jul 2019 20:25:22 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:42128 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730515AbfGLAZV (ORCPT ); Thu, 11 Jul 2019 20:25:21 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6C0O1Os087021; Fri, 12 Jul 2019 00:24:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=/7iUAjA8hocsPRyoS5IWsNkk25nMXlZ5eQiVR+FIJr4=; b=v29BE733dwH3SnVG34MQg+iO6EYVU7rKwB57P7Fk79bMB8zTouHJtPF3QcLyErF0lgPK Arl8iEso7HUGmPgNnGAvvKJio6PxWS/xd0OgG/FQBEbJwgfUSIg27ZQB8OwUPniuSpq9 5+D9vkET/Xg1/C9RrU+TRPGCF3B1OmYd3/oO3qlq8olxq0lsRousudBGnexZkEpY5/VP EQAWPty4cv5/VO0mPMHY1+rZsZU9IehboRmR7iUiL7YfNfDMv9ek2tcQ2F1pF8xezKmt QFQntd1jyJx04XQZBM4ZaO00u7JcYBHGjadR24R257zrVeUfPIwS+p86omF2brc6DSre aA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2tjm9r2tnd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Jul 2019 00:24:24 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6C0NHId106653; Fri, 12 Jul 2019 00:24:23 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2tmwgyfajd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Jul 2019 00:24:23 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x6C0OL8f013001; Fri, 12 Jul 2019 00:24:22 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 11 Jul 2019 17:24:21 -0700 To: Damien Le Moal Cc: linux-scsi@vger.kernel.org, "Martin K . Petersen" , linux-block@vger.kernel.org, Jens Axboe , dm-devel@redhat.com, Mike Snitzer , linux-f2fs-devel@lists.sourceforge.net, Jaegeuk Kim , Christoph Hellwig , Bart Van Assche Subject: Re: [PATCH V6 2/4] block: Kill gfp_t argument of blkdev_report_zones() From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190701050918.27511-1-damien.lemoal@wdc.com> <20190701050918.27511-3-damien.lemoal@wdc.com> Date: Thu, 11 Jul 2019 20:24:18 -0400 In-Reply-To: <20190701050918.27511-3-damien.lemoal@wdc.com> (Damien Le Moal's message of "Mon, 1 Jul 2019 14:09:16 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9315 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=705 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907120003 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9315 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=751 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907120003 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Damien, > Only GFP_KERNEL and GFP_NOIO are used with blkdev_report_zones(). In > preparation of using vmalloc() for large report buffer and zone array > allocations used by this function, remove its "gfp_t gfp_mask" argument > and rely on the caller context to use memalloc_noio_save/restore() where > necessary (block layer zone revalidation and dm-zoned I/O error path). LGTM. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering