From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Chengguang Xu <cgxu519@mykernel.net>
Cc: axboe@kernel.dk, hch@infradead.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v2] block: release bip in a right way in error path
Date: Wed, 24 Jun 2020 08:07:31 -0400 [thread overview]
Message-ID: <yq1v9jg1xcq.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20200624102139.5048-1-cgxu519@mykernel.net> (Chengguang Xu's message of "Wed, 24 Jun 2020 18:21:39 +0800")
Chengguang,
> Release bip using kfree() in error path when that was allocated
> by kmalloc().
Looks good to me.
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-06-24 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 10:21 [PATCH v2] block: release bip in a right way in error path Chengguang Xu
2020-06-24 10:34 ` Christoph Hellwig
2020-06-24 12:07 ` Martin K. Petersen [this message]
2020-06-24 14:49 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1v9jg1xcq.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=cgxu519@mykernel.net \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).