From: 陆朱伟 <alex_lu@realsil.com.cn>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Max Chou <max.chou@realtek.com>
Subject: 答复: [PATCH v2] Bluetooth: btrtl: Save firmware and config
Date: Wed, 14 Aug 2019 07:31:44 +0000 [thread overview]
Message-ID: <0551C926975A174EA8972327741C7889EE81187B@RS-MBS01.realsil.com.cn> (raw)
In-Reply-To: <1BB38E27-5FAD-4402-86C1-6AA47E6BA08A@holtmann.org>
Hi Marcel,
It only saves the latest fw and config for only one device.
I will dig the caching capability of request_firmware first.
Thanks,
BRs,
> Subject: Re: [PATCH v2] Bluetooth: btrtl: Save firmware and config
>
> Hi Alex,
>
> > usb reset resume will cause downloading firmware again and
> > requesting firmware may be failed while host is resuming
> >
> > Signed-off-by: Alex Lu <alex_lu@realsil.com.cn>
> > ---
> > drivers/bluetooth/btrtl.c | 101
> ++++++++++++++++++++++++++++++++++++--
> > 1 file changed, 97 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> > index 208feef63de4..416a5cb676e3 100644
> > --- a/drivers/bluetooth/btrtl.c
> > +++ b/drivers/bluetooth/btrtl.c
> > @@ -56,6 +56,8 @@ struct btrtl_device_info {
> > int cfg_len;
> > };
> >
> > +static struct btrtl_device_info dev_info;
> > +
>
> No. We are are not using magic global variables. What happens if you attach
> more than one device? Also I assumed that request_firmware has a caching
> capability of sorts so that drivers don’t have to re-implement caching of the
> firmware.
>
> Regards
>
> Marcel
>
>
> ------Please consider the environment before printing this e-mail.
prev parent reply other threads:[~2019-08-14 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 3:07 [PATCH v2] Bluetooth: btrtl: Save firmware and config Alex Lu
2019-08-12 16:35 ` Marcel Holtmann
2019-08-14 7:31 ` 陆朱伟 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0551C926975A174EA8972327741C7889EE81187B@RS-MBS01.realsil.com.cn \
--to=alex_lu@realsil.com.cn \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=max.chou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).