linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: David Summers <beagleboard@davidjohnsummers.uk>
Cc: "open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>
Subject: Re: drivers/bluetooth/Kconfig BT_HCIUART_RTL depends on ACPI
Date: Mon, 18 Feb 2019 11:48:12 +0100	[thread overview]
Message-ID: <07109476-C017-4DC2-98A7-2EE5B53C4AB3@holtmann.org> (raw)
In-Reply-To: <9d693bec-56c7-58a1-67b8-ba9edd63989d@davidjohnsummers.uk>

Hi David,

> On Arch Linux Arm, have a couple of people helping with the Tinker Board Patches - think we are close to something that may get passed.
> 
> Now testing it far more, and a snag, drivers/bluetooth/Kconfig contains:
> 
> config BT_HCIUART_RTL
>     bool "Realtek protocol support"
>     depends on BT_HCIUART
>     depends on BT_HCIUART_SERDEV
>     depends on GPIOLIB
>     depends on ACPI
>     select BT_HCIUART_3WIRE
>     select BT_RTL
> 
> But why does it depend on ACPI? I haven't found a way of setting that in 4.20, used to be in Power Management IIRC - but can't find now.
> 
> find . -name Kconfig -type f -exec grep "select ACPI" '{}' \;
> 
> Doesn't find anything to select ACPI …

initially we only supported Realtek chips that are described via ACPI. For DT based ones you need to extend this. The Broadcom ones uses this line:

depends on (!ACPI || SERIAL_DEV_CTRL_TTYPORT)

Maybe this works here as well.

Regards

Marcel


  reply	other threads:[~2019-02-18 10:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 20:36 drivers/bluetooth/Kconfig BT_HCIUART_RTL depends on ACPI David Summers
2019-02-18 10:48 ` Marcel Holtmann [this message]
2019-02-18 20:05   ` David Summers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07109476-C017-4DC2-98A7-2EE5B53C4AB3@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=beagleboard@davidjohnsummers.uk \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).