linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stotland, Inga" <inga.stotland@intel.com>
To: "michal.lowas-rzechonek@silvair.com" 
	<michal.lowas-rzechonek@silvair.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ v2 2/5] mesh: Validate application by comparing composition data
Date: Wed, 24 Jul 2019 21:24:11 +0000	[thread overview]
Message-ID: <0b15073aa143b3036d19c74884219cd16c7278fa.camel@intel.com> (raw)
In-Reply-To: <20190724191241.ad4vri23hs2zqyce@kynes>

[-- Attachment #1: Type: text/plain, Size: 1824 bytes --]

Hi Michal,

On Wed, 2019-07-24 at 21:12 +0200, michal.lowas-rzechonek@silvair.com
wrote:
> Hi Inga,
> 
> On 07/24, Stotland, Inga wrote:
> > > > So here, prior to removing the temorary node, the element paths
> > > > need to be copied into the "req->attach" version of the node.
> > > > Same goes for node->agent and node->provisioner.	
> > > 
> > > True, thanks! I'll fix this in v3.
> > 
> > Also, could you please add some comment there, like "Deleting the
> > temporary node" just to make the point that tit was temporary? I am
> > afraid that for an outside person this will not be clear why the
> > node
> > is being removed.
> 
> Sure thing.
> 
> > > > "Location" property is described as optional in mesh-api.txt.
> > > > It's
> > > > populated with "Default Location", if the property is not
> > > > present.
> (...)
> > Let's try to keep it as optional then.
> 
> Will do.
> 
> > This will require some *fuzzy* matching of the composition data,
> > something like:
> > add a boolean flag to generate_node_composition() that indicates
> > whether the composition is generated for the verification or as a
> > result of an external request, i.e. for the config server model.
> > Based
> > on the flag, either include location field, or not.
> 
> I don't think I follow. If the application doesn't provide the
> "Location" property, everything behaves as if it provided it with
> value
> "0", no?
> 
> Location descriptor is *not* optional in Composition Data (Table 4.4
> in
> section 4.2.1.1).
> 
> 


Never mind, I was overthinking this. Even if the property is
*optional*, the value (or the fact of its presense) is not supposed to
change.
Let's keep it optional, and, just as it is currently, and it be
populated with "Default Location" if it's not found. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3265 bytes --]

  reply	other threads:[~2019-07-24 21:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 10:06 [PATCH BlueZ v2 0/5] Use composition data to validate app against the node Michał Lowas-Rzechonek
2019-07-23 10:06 ` [PATCH BlueZ v2 1/5] mesh: Convert void pointers to anonymous unions in managed_obj_request Michał Lowas-Rzechonek
2019-07-23 10:06 ` [PATCH BlueZ v2 2/5] mesh: Validate application by comparing composition data Michał Lowas-Rzechonek
2019-07-24  4:30   ` Stotland, Inga
2019-07-24  7:55     ` michal.lowas-rzechonek
2019-07-24 18:09       ` Stotland, Inga
2019-07-24 19:12         ` michal.lowas-rzechonek
2019-07-24 21:24           ` Stotland, Inga [this message]
2019-07-23 10:06 ` [PATCH BlueZ v2 3/5] mesh: Keep element and model lists sorted and unique Michał Lowas-Rzechonek
2019-07-23 10:06 ` [PATCH BlueZ v2 4/5] mesh: Check that element indexes are consecutive Michał Lowas-Rzechonek
2019-07-23 10:06 ` [PATCH BlueZ v2 5/5] mesh: Check that config server is present in primary element Michał Lowas-Rzechonek
2019-07-24  4:38 ` [PATCH BlueZ v2 0/5] Use composition data to validate app against the node Stotland, Inga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b15073aa143b3036d19c74884219cd16c7278fa.camel@intel.com \
    --to=inga.stotland@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=michal.lowas-rzechonek@silvair.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).