From: Marcel Holtmann <marcel@holtmann.org>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH v2 14/14] Bluetooth: mgmt: Use command complete on success for set system config
Date: Wed, 17 Jun 2020 16:39:20 +0200 [thread overview]
Message-ID: <13f017e592c175aa4af83f09521305da3c7edd74.1592404644.git.marcel@holtmann.org> (raw)
In-Reply-To: <cover.1592404644.git.marcel@holtmann.org>
The command status reply is only for failure. When completing set system
config command, the reply has to be command complete.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Reviewed-by: Alain Michaud <alainm@chromium.org>
---
net/bluetooth/mgmt_config.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/bluetooth/mgmt_config.c b/net/bluetooth/mgmt_config.c
index 8e7ad2a51dbb..8d01a8ff85e9 100644
--- a/net/bluetooth/mgmt_config.c
+++ b/net/bluetooth/mgmt_config.c
@@ -247,9 +247,8 @@ int set_def_system_config(struct sock *sk, struct hci_dev *hdev, void *data,
buffer += exp_len;
}
- return mgmt_cmd_status(sk, hdev->id,
- MGMT_OP_SET_DEF_SYSTEM_CONFIG,
- MGMT_STATUS_SUCCESS);
+ return mgmt_cmd_complete(sk, hdev->id,
+ MGMT_OP_SET_DEF_SYSTEM_CONFIG, 0, NULL, 0);
}
int read_def_runtime_config(struct sock *sk, struct hci_dev *hdev, void *data,
--
2.26.2
next prev parent reply other threads:[~2020-06-17 14:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 14:39 [PATCH v2 00/14] Combination of pending patches Marcel Holtmann
2020-06-17 14:39 ` [PATCH v2 01/14] Bluetooth: mgmt: Add commands for runtime configuration Marcel Holtmann
2020-06-17 14:39 ` [PATCH v2 02/14] Bluetooth: Add bdaddr_list_with_flags for classic whitelist Marcel Holtmann
2020-06-17 14:39 ` [PATCH v2 03/14] Bluetooth: Replace wakeable list with flag Marcel Holtmann
2020-06-17 14:39 ` [PATCH v2 04/14] Bluetooth: Replace wakeable in hci_conn_params Marcel Holtmann
2020-06-17 14:39 ` [PATCH v2 05/14] Bluetooth: Add get/set device flags mgmt op Marcel Holtmann
2020-06-17 18:03 ` Abhishek Pandit-Subedi
2020-06-17 14:39 ` [PATCH v2 06/14] Bluetooth: Add definitions for advertisement monitor features Marcel Holtmann
2020-06-17 14:39 ` [PATCH v2 07/14] Bluetooth: Add handler of MGMT_OP_READ_ADV_MONITOR_FEATURES Marcel Holtmann
2020-06-17 14:39 ` [PATCH v2 08/14] Bluetooth: Add handler of MGMT_OP_ADD_ADV_PATTERNS_MONITOR Marcel Holtmann
2020-06-17 14:39 ` [PATCH v2 09/14] Bluetooth: Add handler of MGMT_OP_REMOVE_ADV_MONITOR Marcel Holtmann
2020-06-17 14:39 ` [PATCH v2 10/14] Bluetooth: Notify adv monitor added event Marcel Holtmann
2020-06-17 14:39 ` [PATCH v2 11/14] Bluetooth: Notify adv monitor removed event Marcel Holtmann
2020-06-17 14:39 ` [PATCH v2 12/14] Bluetooth: Update background scan and report device based on advertisement monitors Marcel Holtmann
[not found] ` <CGME20200629223028eucas1p27b9482456072d7864f7505379885a0b4@eucas1p2.samsung.com>
2020-06-29 22:30 ` Marek Szyprowski
2020-06-30 6:49 ` Marcel Holtmann
2020-06-30 7:36 ` Marek Szyprowski
2020-06-17 14:39 ` [PATCH v2 13/14] Bluetooth: Terminate the link if pairing is cancelled Marcel Holtmann
2020-06-17 14:39 ` Marcel Holtmann [this message]
2020-06-18 10:17 ` [PATCH v2 00/14] Combination of pending patches Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13f017e592c175aa4af83f09521305da3c7edd74.1592404644.git.marcel@holtmann.org \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).