From: "Gix, Brian" <brian.gix@intel.com>
To: "linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"Stotland, Inga" <inga.stotland@intel.com>
Subject: Re: [PATCH BlueZ] test/test-mesh: Initialize required properties
Date: Fri, 26 Jul 2019 16:20:04 +0000 [thread overview]
Message-ID: <1564158003.16999.2.camel@intel.com> (raw)
In-Reply-To: <20190725183145.23604-1-inga.stotland@intel.com>
Applied
On Thu, 2019-07-25 at 11:31 -0700, Inga Stotland wrote:
> This initialized required "Models" and "VendorModels" properties
> wheher the actual models exist or not, according to the mesh-api.txt.
> In case when an element does not contain either SIG defined models or
> vendor defineed models, the corresponding properties should contain
> empty arrays.
> ---
> test/test-mesh | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/test/test-mesh b/test/test-mesh
> index 6e9196366..3c5ded7b3 100755
> --- a/test/test-mesh
> +++ b/test/test-mesh
> @@ -537,10 +537,8 @@ class Element(dbus.service.Object):
> sig_models = self._get_sig_models()
>
> props = {'Index' : dbus.Byte(self.index)}
> - if len(sig_models) != 0:
> - props['Models'] = dbus.Array(sig_models, signature='q')
> - if len(vendor_models) != 0:
> - props['VendorModels'] = dbus.Array(vendor_models,
> + props['Models'] = dbus.Array(sig_models, signature='q')
> + props['VendorModels'] = dbus.Array(vendor_models,
> signature='(qq)')
> #print(props)
> return { MESH_ELEMENT_IFACE: props }
prev parent reply other threads:[~2019-07-26 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 18:31 [PATCH BlueZ] test/test-mesh: Initialize required properties Inga Stotland
2019-07-26 16:20 ` Gix, Brian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564158003.16999.2.camel@intel.com \
--to=brian.gix@intel.com \
--cc=inga.stotland@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).