* [PATCH v1] Bluetooth: hci_qca: Skip 1 error print in device_want_to_sleep()
@ 2019-08-14 7:42 Rocky Liao
2019-08-14 13:51 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Rocky Liao @ 2019-08-14 7:42 UTC (permalink / raw)
To: marcel, johan.hedberg; +Cc: linux-kernel, linux-bluetooth, Rocky Liao
Don't fall through to print error message when receive sleep indication
in HCI_IBS_RX_ASLEEP state, this is allowed behavior.
Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
---
drivers/bluetooth/hci_qca.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index a054210..2affb4e 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -686,7 +686,7 @@ static void device_want_to_sleep(struct hci_uart *hu)
unsigned long flags;
struct qca_data *qca = hu->priv;
- BT_DBG("hu %p want to sleep", hu);
+ BT_DBG("hu %p want to sleep in %d state", hu, qca->rx_ibs_state);
spin_lock_irqsave(&qca->hci_ibs_lock, flags);
@@ -701,7 +701,7 @@ static void device_want_to_sleep(struct hci_uart *hu)
break;
case HCI_IBS_RX_ASLEEP:
- /* Fall through */
+ break;
default:
/* Any other state is illegal */
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] Bluetooth: hci_qca: Skip 1 error print in device_want_to_sleep()
2019-08-14 7:42 [PATCH v1] Bluetooth: hci_qca: Skip 1 error print in device_want_to_sleep() Rocky Liao
@ 2019-08-14 13:51 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2019-08-14 13:51 UTC (permalink / raw)
To: Rocky Liao; +Cc: Johan Hedberg, linux-kernel, linux-bluetooth
Hi Rocky,
> Don't fall through to print error message when receive sleep indication
> in HCI_IBS_RX_ASLEEP state, this is allowed behavior.
>
> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
> ---
> drivers/bluetooth/hci_qca.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
patch has been applied to bluetooth-stable tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-14 13:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-14 7:42 [PATCH v1] Bluetooth: hci_qca: Skip 1 error print in device_want_to_sleep() Rocky Liao
2019-08-14 13:51 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).