Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH BlueZ] meshctl truncates GATT MTU
@ 2019-09-28 14:14 Michael N. Moran
  2019-09-28 14:14 ` [PATCH BlueZ] The meshctl sock_write() max_len variable is declared as a uint8_t, which causes the calculation of the GATT MTU to be truncated when the MTU (write_mtu) is greater than 259. This error causes incorrect segmentation Michael N. Moran
  0 siblings, 1 reply; 2+ messages in thread
From: Michael N. Moran @ 2019-09-28 14:14 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Michael N. Moran

From: "Michael N. Moran" <mike@mnmoran.org>

This patch fixes a bug in meshctl that causes the
GATT MTU to be truncated resulting in incorrect
segmentation when the MTU is greater than 259.

Michael N. Moran (1):
  The meshctl sock_write() max_len variable is declared as
    uint8_t, which causes the calculation of the GATT MTU
	to be truncated when the MTU (write_mtu) is greater
	than 259. This error causes incorrect segmentation.

 tools/mesh/gatt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH BlueZ] The meshctl sock_write() max_len variable is declared as a uint8_t, which causes the calculation of the GATT MTU to be truncated when the MTU (write_mtu) is greater than 259. This error causes incorrect segmentation.
  2019-09-28 14:14 [PATCH BlueZ] meshctl truncates GATT MTU Michael N. Moran
@ 2019-09-28 14:14 ` Michael N. Moran
  0 siblings, 0 replies; 2+ messages in thread
From: Michael N. Moran @ 2019-09-28 14:14 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Michael N. Moran

From: "Michael N. Moran" <mike@mnmoran.org>

---
 tools/mesh/gatt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/mesh/gatt.c b/tools/mesh/gatt.c
index 0a942d4..c9e789c 100644
--- a/tools/mesh/gatt.c
+++ b/tools/mesh/gatt.c
@@ -189,7 +189,7 @@ static bool sock_write(struct io *io, void *user_data)
 	struct write_data *data = user_data;
 	struct iovec iov[2];
 	uint8_t sar;
-	uint8_t max_len;
+	uint16_t max_len;
 
 	if (data == NULL)
 		return true;
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-28 14:14 [PATCH BlueZ] meshctl truncates GATT MTU Michael N. Moran
2019-09-28 14:14 ` [PATCH BlueZ] The meshctl sock_write() max_len variable is declared as a uint8_t, which causes the calculation of the GATT MTU to be truncated when the MTU (write_mtu) is greater than 259. This error causes incorrect segmentation Michael N. Moran

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git