From: Bastien Nocera <hadess@hadess.net>
To: Archie Pusaka <apusaka@google.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
CrosBT Upstreaming <chromeos-bluetooth-upstreaming@chromium.org>,
Archie Pusaka <apusaka@chromium.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] Bluetooth: use inclusive language in HCI role comments
Date: Fri, 04 Jun 2021 11:09:19 +0200 [thread overview]
Message-ID: <1fc00ee63fcb2be29148e33be1f013a154caf287.camel@hadess.net> (raw)
In-Reply-To: <CAJQfnxHtgsCTS5GCTj-p4iqaR=jZVPho1ELgFQ6-UngZcBECig@mail.gmail.com>
On Fri, 2021-06-04 at 16:56 +0800, Archie Pusaka wrote:
> Hi Bastien,
>
> Thanks! That was a great input.
> I'm not sure though, do we have a standard, proper way to deprecate
> macros?
> Or does a simple /* deprecated */ comment works for now?
I think we might need to add #ifdef around those instead unfortunately,
something like "#ifndef BLUETOOTH_NO_DEPRECATED_CONSTANTS" around the
old names.
>
> Cheers,
> Archie
>
>
> On Fri, 4 Jun 2021 at 16:39, Bastien Nocera <hadess@hadess.net>
> wrote:
> >
> > On Fri, 2021-06-04 at 16:26 +0800, Archie Pusaka wrote:
> > >
> > > The #define preprocessor terms are unchanged for now to not
> > > disturb
> > > dependent APIs.
> >
> > Could we add new defines, and deprecate the old ones? Something
> > akin
> > to that would help migrate the constants, over time:
> > https://gitlab.gnome.org/GNOME/glib/blob/master/glib/gmacros.h#L686-716
> >
next prev parent reply other threads:[~2021-06-04 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 8:26 [PATCH v3 1/3] Bluetooth: use inclusive language in HCI role comments Archie Pusaka
2021-06-04 8:26 ` [PATCH v3 2/3] Bluetooth: use inclusive language when tracking connections Archie Pusaka
2021-06-04 8:26 ` [PATCH v3 3/3] Bluetooth: use inclusive language when filtering devices Archie Pusaka
2021-06-04 8:38 ` [PATCH v3 1/3] Bluetooth: use inclusive language in HCI role comments Bastien Nocera
2021-06-04 8:56 ` Archie Pusaka
2021-06-04 9:09 ` Bastien Nocera [this message]
2021-06-04 10:26 ` [v3,1/3] " bluez.test.bot
2021-06-04 15:27 ` [PATCH v3 1/3] " Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fc00ee63fcb2be29148e33be1f013a154caf287.camel@hadess.net \
--to=hadess@hadess.net \
--cc=apusaka@chromium.org \
--cc=apusaka@google.com \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).