From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 625FAC04EBF for ; Tue, 4 Dec 2018 20:41:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32CB320834 for ; Tue, 4 Dec 2018 20:41:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32CB320834 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726268AbeLDUlW (ORCPT ); Tue, 4 Dec 2018 15:41:22 -0500 Received: from mga01.intel.com ([192.55.52.88]:55190 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbeLDUlW (ORCPT ); Tue, 4 Dec 2018 15:41:22 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2018 12:41:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,315,1539673200"; d="scan'208";a="106987660" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga008.fm.intel.com with SMTP; 04 Dec 2018 12:41:18 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 04 Dec 2018 22:41:17 +0200 From: Ville Syrjala To: linux-bluetooth@vger.kernel.org Cc: Dmitry Torokhov , Greg Kroah-Hartman , Marcel Holtmann , Kay Sievers , =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= , systemd-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 BlueZ] hid2hci: Fix udev rules for linux-4.14+ Date: Tue, 4 Dec 2018 22:41:17 +0200 Message-Id: <20181204204117.14964-1-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20180620164240.6535-1-ville.syrjala@linux.intel.com> References: <20180620164240.6535-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Ville Syrjälä Since commit 1455cf8dbfd0 ("driver core: emit uevents when device is bound to a driver") the kernel started emitting "bind" and "unbind" uevents which confuse the hid2hci udev rules. The symptoms on an affected machine (Dell E5400 in my case) include bluetooth devices not appearing and udev hogging the cpu as it's busy processing a constant stream of these "bind"+"unbind" uevents. Change the udev rules not do anything except for "add" and "change" events. This seems to cure my machine at least. v2: Don't mess up "change" (Zbyszek) Fix up the commit message a bit Cc: Dmitry Torokhov Cc: Greg Kroah-Hartman Cc: Marcel Holtmann Cc: Kay Sievers Cc: Zbigniew Jędrzejewski-Szmek Cc: systemd-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Cc: linux-bluetooth@vger.kernel.org --- Reposting with BlueZ in subject and sob stripped. Maybe that helps in getting a oneliner merged? tools/hid2hci.rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/hid2hci.rules b/tools/hid2hci.rules index db6bb03d2ef3..5c7208af7a02 100644 --- a/tools/hid2hci.rules +++ b/tools/hid2hci.rules @@ -1,6 +1,6 @@ # do not edit this file, it will be overwritten on update -ACTION=="remove", GOTO="hid2hci_end" +ACTION!="add|change", GOTO="hid2hci_end" SUBSYSTEM!="usb*", GOTO="hid2hci_end" # Variety of Dell Bluetooth devices - match on a mouse device that is -- 2.16.4