[PATCH] bluetooth: hci_intel: Check for driver register failure

[PATCH] bluetooth: hci_intel: Check for driver register failure

[Aditya Pakki]

While initializing the driver, the function platform_driver_register can
fail and return an error. Consistent with other invocations, this patch
returns the error upstream.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
 drivers/bluetooth/hci_intel.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/hci_intel.c b/drivers/bluetooth/hci_intel.c
index f31410526c57..8450389a2017 100644
--- a/drivers/bluetooth/hci_intel.c
+++ b/drivers/bluetooth/hci_intel.c
@@ -1242,7 +1242,11 @@ static struct platform_driver intel_driver = {
 
 int __init intel_init(void)
 {
-	platform_driver_register(&intel_driver);
+	int rc;
+
+	rc = platform_driver_register(&intel_driver);
+	if (rc)
+		return rc;
 
 	return hci_uart_register_proto(&intel_proto);
 }
-- 
2.17.1

Re: [PATCH] bluetooth: hci_intel: Check for driver register failure

[Marcel Holtmann]

Hi Aditya,

> While initializing the driver, the function platform_driver_register can
> fail and return an error. Consistent with other invocations, this patch
> returns the error upstream.
> 
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> drivers/bluetooth/hci_intel.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/hci_intel.c b/drivers/bluetooth/hci_intel.c
> index f31410526c57..8450389a2017 100644
> --- a/drivers/bluetooth/hci_intel.c
> +++ b/drivers/bluetooth/hci_intel.c
> @@ -1242,7 +1242,11 @@ static struct platform_driver intel_driver = {
> 
> int __init intel_init(void)
> {
> -	platform_driver_register(&intel_driver);
> +	int rc;
> +
> +	rc = platform_driver_register(&intel_driver);
> +	if (rc)
> +		return rc;

same here. Let this fail since even if it fails, the rest of the driver will be still functioning.

Regards

Marcel