Linux-Bluetooth Archive on lore.kernel.org
 help / Atom feed
* [PATCH 1/2] bluetooth: btmrvl_sdio: improve printk messages
@ 2019-01-11 20:56 Stefan Agner
  2019-01-11 20:56 ` [PATCH 2/2] bluetooth: btmrvl_sdio: lower log level of informational message Stefan Agner
  2019-01-18  9:14 ` [PATCH 1/2] bluetooth: btmrvl_sdio: improve printk messages Marcel Holtmann
  0 siblings, 2 replies; 4+ messages in thread
From: Stefan Agner @ 2019-01-11 20:56 UTC (permalink / raw)
  To: marcel, johan.hedberg; +Cc: huxm, linux-bluetooth, linux-kernel, Stefan Agner

Use dev_* variants to print messages in drivers.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 drivers/bluetooth/btmrvl_sdio.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index fb3d03928460..6f9a1735039d 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -62,13 +62,14 @@ static const struct of_device_id btmrvl_sdio_of_match_table[] = {
 static irqreturn_t btmrvl_wake_irq_bt(int irq, void *priv)
 {
 	struct btmrvl_sdio_card *card = priv;
+	struct device *dev = &card->func->dev;
 	struct btmrvl_plt_wake_cfg *cfg = card->plt_wake_cfg;
 
-	pr_info("%s: wake by bt\n", __func__);
+	dev_info(dev, "wake by bt\n");
 	cfg->wake_by_bt = true;
 	disable_irq_nosync(irq);
 
-	pm_wakeup_event(&card->func->dev, 0);
+	pm_wakeup_event(dev, 0);
 	pm_system_wakeup();
 
 	return IRQ_HANDLED;
@@ -87,7 +88,7 @@ static int btmrvl_sdio_probe_of(struct device *dev,
 
 	if (!dev->of_node ||
 	    !of_match_node(btmrvl_sdio_of_match_table, dev->of_node)) {
-		pr_err("sdio platform data not available\n");
+		dev_err(dev, "sdio platform data not available\n");
 		return -1;
 	}
 
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] bluetooth: btmrvl_sdio: lower log level of informational message
  2019-01-11 20:56 [PATCH 1/2] bluetooth: btmrvl_sdio: improve printk messages Stefan Agner
@ 2019-01-11 20:56 ` Stefan Agner
  2019-01-18  9:15   ` Marcel Holtmann
  2019-01-18  9:14 ` [PATCH 1/2] bluetooth: btmrvl_sdio: improve printk messages Marcel Holtmann
  1 sibling, 1 reply; 4+ messages in thread
From: Stefan Agner @ 2019-01-11 20:56 UTC (permalink / raw)
  To: marcel, johan.hedberg; +Cc: huxm, linux-bluetooth, linux-kernel, Stefan Agner

The platform specific wake-up interrupt is optional. Don't print
an error message in case it is missing, merely inform the user in
this case.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 drivers/bluetooth/btmrvl_sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index 6f9a1735039d..8ff4c31e0e48 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -88,7 +88,7 @@ static int btmrvl_sdio_probe_of(struct device *dev,
 
 	if (!dev->of_node ||
 	    !of_match_node(btmrvl_sdio_of_match_table, dev->of_node)) {
-		dev_err(dev, "sdio platform data not available\n");
+		dev_info(dev, "sdio device tree data not available\n");
 		return -1;
 	}
 
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] bluetooth: btmrvl_sdio: improve printk messages
  2019-01-11 20:56 [PATCH 1/2] bluetooth: btmrvl_sdio: improve printk messages Stefan Agner
  2019-01-11 20:56 ` [PATCH 2/2] bluetooth: btmrvl_sdio: lower log level of informational message Stefan Agner
@ 2019-01-18  9:14 ` Marcel Holtmann
  1 sibling, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2019-01-18  9:14 UTC (permalink / raw)
  To: Stefan Agner; +Cc: Johan Hedberg, huxm, linux-bluetooth, linux-kernel

Hi Stefan,

> Use dev_* variants to print messages in drivers.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> drivers/bluetooth/btmrvl_sdio.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] bluetooth: btmrvl_sdio: lower log level of informational message
  2019-01-11 20:56 ` [PATCH 2/2] bluetooth: btmrvl_sdio: lower log level of informational message Stefan Agner
@ 2019-01-18  9:15   ` Marcel Holtmann
  0 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2019-01-18  9:15 UTC (permalink / raw)
  To: Stefan Agner; +Cc: Johan Hedberg, huxm, linux-bluetooth, linux-kernel

Hi Stefan,

> The platform specific wake-up interrupt is optional. Don't print
> an error message in case it is missing, merely inform the user in
> this case.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> drivers/bluetooth/btmrvl_sdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11 20:56 [PATCH 1/2] bluetooth: btmrvl_sdio: improve printk messages Stefan Agner
2019-01-11 20:56 ` [PATCH 2/2] bluetooth: btmrvl_sdio: lower log level of informational message Stefan Agner
2019-01-18  9:15   ` Marcel Holtmann
2019-01-18  9:14 ` [PATCH 1/2] bluetooth: btmrvl_sdio: improve printk messages Marcel Holtmann

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org linux-bluetooth@archiver.kernel.org
	public-inbox-index linux-bluetooth


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/ public-inbox