linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Myungho Jung <mhjungk@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_uart: Add a local variable to store the result of h4_recv_buf()
Date: Sat, 19 Jan 2019 00:19:20 -0800	[thread overview]
Message-ID: <20190119081919.GA10681@myunghoj-Precision-5530> (raw)
In-Reply-To: <09FCB21A-2184-4CDB-8BF0-75C403DF39F9@holtmann.org>

On Fri, Jan 18, 2019 at 10:19:41AM +0100, Marcel Holtmann wrote:
> Hi Myungho,
> 
> > In h4_recv(), if h4_recv_buf() returns error and h4_recv() is
> > asynchronously called again before setting rx_skb to NULL, ERR_PTR will
> > be dereferenced in h4_recv_buf(). Check return value in a local variable
> > before writing to rx_skb.
> > 
> > Reported-by: syzbot+017a32f149406df32703@syzkaller.appspotmail.com
> > Signed-off-by: Myungho Jung <mhjungk@gmail.com>
> > ---
> > drivers/bluetooth/hci_h4.c | 11 +++++++----
> > 1 file changed, 7 insertions(+), 4 deletions(-)
> 
> patch has been applied to bluetooth-next tree.
> 
> Can you actually fix all callers of h4_recv_buf since they all suffer from the same issue.
> 
> Regards
> 
> Marcel
> 

Hi Marcel,

Sure, let me check other callers and fix them if applicable.

Thanks,
Myungho


  reply	other threads:[~2019-01-19  8:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11  6:55 [PATCH] Bluetooth: hci_uart: Add a local variable to store the result of h4_recv_buf() Myungho Jung
2019-01-18  9:19 ` Marcel Holtmann
2019-01-19  8:19   ` Myungho Jung [this message]
2019-01-20  9:45     ` Myungho Jung
2019-01-21 14:48       ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190119081919.GA10681@myunghoj-Precision-5530 \
    --to=mhjungk@gmail.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).