From: Matthias Kaehlcke <mka@chromium.org>
To: Johan Hovold <johan@kernel.org>
Cc: Balakrishna Godavarthi <bgodavar@codeaurora.org>,
marcel@holtmann.org, johan.hedberg@gmail.com,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org,
Johan Hovold <jhovold@gmail.com>
Subject: Re: [PATCH v5 2/5] Bluetooth: hci_qca: Deassert RTS while baudrate change command
Date: Tue, 22 Jan 2019 13:39:36 -0800 [thread overview]
Message-ID: <20190122213936.GH261387@google.com> (raw)
In-Reply-To: <20190121085613.GG3691@localhost>
On Mon, Jan 21, 2019 at 09:56:13AM +0100, Johan Hovold wrote:
> On Fri, Jan 18, 2019 at 04:31:09PM -0800, Matthias Kaehlcke wrote:
> > On Fri, Jan 18, 2019 at 10:44:16AM +0100, Johan Hovold wrote:
> > > On Thu, Jan 17, 2019 at 09:21:09AM -0800, Matthias Kaehlcke wrote:
> > >
> > > > I observed that the qcom_geni_serial driver doesn't raise RTS with
> > > > flow control disabled. It seems we have to investigate why that's the
> > > > case. I agree that the driver should be platform agnostic.
> > >
> > > Sounds like a driver bug, unless the hardware is just "odd". The
> > > driver implementation of this looks very non-standard judging from a
> > > quick peek.
> > >
> > > In fact, qcom_geni_serial_get_mctrl() is currently a no-op if hardware
> > > flow control is not enabled:
> > >
> > > if (uart_console(uport) || !uart_cts_enabled(uport))
> > > return;
> > >
> > > Perhaps dropping the !uart_cts_enabled() test is sufficient.
> >
> > Thanks for taking a look Johan, that was indeed the problem (also
> > in set_mctrl()). I posted a fix: https://lore.kernel.org/patchwork/patch/1033611/
>
> Nice (I did mean set_mctrl() above, as I think you noticed).
>
> > Balakrishna, the following (applied on top of your patch) works for me
> > with the UART patch above:
> >
> > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> > index 9d5e41f159c78f..60bfdf01f72841 100644
> > --- a/drivers/bluetooth/hci_qca.c
> > +++ b/drivers/bluetooth/hci_qca.c
> > @@ -1080,7 +1080,7 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type)
> > {
> > unsigned int speed, qca_baudrate;
> > struct qca_serdev *qcadev;
> > - int ret;
> > + int ret = 0;
> >
> > if (speed_type == QCA_INIT_SPEED) {
> > speed = qca_get_speed(hu, QCA_INIT_SPEED);
> > @@ -1097,22 +1097,27 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type)
> > * the old speed.
> > */
> > qcadev = serdev_device_get_drvdata(hu->serdev);
> > - if (qcadev->btsoc_type == QCA_WCN3990)
> > + if (qcadev->btsoc_type == QCA_WCN3990) {
> > + hci_uart_set_flow_control(hu, true);
>
> Wow, yeah, this parameter inversion is indeed confusing...
>
> > serdev_device_set_rts(hu->serdev, false);
> > + }
>
> But looking at hci_uart_set_flow_control() now, it actually also
> deasserts RTS. So all you need here is the hci_uart_set_flow_control()
> call.
Great, thanks for pointing that out!
> And that makes the inversion make a bit more sense too, even if the
> naming is a bit unfortunate with respect to
> serdev_device_set_flow_control() at least.
next prev parent reply other threads:[~2019-01-22 21:39 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 14:46 [PATCH v5 0/5] Bug fixes for Qualcomm BT chip wcn3990 Balakrishna Godavarthi
2018-12-20 14:46 ` [PATCH v5 1/5] Bluetooth: hci_qca: use wait_until_sent() for power pulses Balakrishna Godavarthi
2018-12-22 1:59 ` Matthias Kaehlcke
2018-12-26 6:31 ` Balakrishna Godavarthi
2018-12-26 22:21 ` Matthias Kaehlcke
2018-12-27 3:23 ` Balakrishna Godavarthi
2019-01-09 14:38 ` Johan Hovold
2019-01-10 14:48 ` Balakrishna Godavarthi
2019-01-11 0:55 ` Matthias Kaehlcke
2019-01-11 14:32 ` Balakrishna Godavarthi
2019-01-11 23:38 ` Matthias Kaehlcke
2019-01-14 10:25 ` Balakrishna Godavarthi
2018-12-20 14:46 ` [PATCH v5 2/5] Bluetooth: hci_qca: Deassert RTS while baudrate change command Balakrishna Godavarthi
2018-12-22 0:31 ` Matthias Kaehlcke
2018-12-26 5:45 ` Balakrishna Godavarthi
2018-12-26 20:25 ` Matthias Kaehlcke
2018-12-27 3:20 ` Balakrishna Godavarthi
2019-01-09 14:52 ` Johan Hovold
2019-01-10 14:34 ` Balakrishna Godavarthi
2019-01-10 14:39 ` Johan Hovold
2019-01-10 14:52 ` Balakrishna Godavarthi
2019-01-11 1:37 ` Matthias Kaehlcke
2019-01-11 15:07 ` Balakrishna Godavarthi
2019-01-11 23:56 ` Matthias Kaehlcke
2019-01-14 14:52 ` Balakrishna Godavarthi
2019-01-15 23:46 ` Matthias Kaehlcke
2019-01-17 16:09 ` Johan Hovold
2019-01-17 17:21 ` Matthias Kaehlcke
2019-01-18 9:44 ` Johan Hovold
2019-01-19 0:31 ` Matthias Kaehlcke
2019-01-21 8:56 ` Johan Hovold
2019-01-22 21:39 ` Matthias Kaehlcke [this message]
2019-01-21 14:41 ` Balakrishna Godavarthi
2019-01-22 21:53 ` Matthias Kaehlcke
2019-01-23 12:57 ` Balakrishna Godavarthi
2018-12-20 14:46 ` [PATCH v5 3/5] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990 Balakrishna Godavarthi
2018-12-20 14:46 ` [PATCH v5 4/5] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer Balakrishna Godavarthi
2018-12-20 14:46 ` [PATCH v5 5/5] Bluetooth: btqca: inject command complete event during fw download Balakrishna Godavarthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122213936.GH261387@google.com \
--to=mka@chromium.org \
--cc=bgodavar@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=jhovold@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=johan@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).