From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E93C282C8 for ; Mon, 28 Jan 2019 17:47:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7ABCD2177B for ; Mon, 28 Jan 2019 17:47:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="O0d3tKDv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728224AbfA1Rrx (ORCPT ); Mon, 28 Jan 2019 12:47:53 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:39847 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728331AbfA1Rrw (ORCPT ); Mon, 28 Jan 2019 12:47:52 -0500 Received: by mail-pl1-f193.google.com with SMTP id 101so8055311pld.6 for ; Mon, 28 Jan 2019 09:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=X1DYq2EInMW1RIwYMjFNGIpURLtPoNcFDZyXw9tEIgw=; b=O0d3tKDv6J2n4rX8yLn7Mv1g3EENRpxz8l5QWIVIfqlDokP0yU+odUoChELGuHCDkl CnA076/T50QsCDGvSlEZp3bfx7y7rOVlNvCqsNHo2wHfuVbWBp/aDjTeBdJWw7D2Hm67 EDRpkDLp78EBHe5kWoWf3026homvyWA08yRqM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=X1DYq2EInMW1RIwYMjFNGIpURLtPoNcFDZyXw9tEIgw=; b=tjotb8pey9EneqBUyE7qyZmZ9KXWtphE0xvPoJa/QfwmbzBM/B0Fg6y+hpZXQT2/Ku ZxdKA1hlVvV4yU7YsibEUiTZLkreD+4i1yHO92b90OjyWvTMti4fEs2HhBf1Sru4fkfb oVbB9yVQq7uS7J7jSXcXcbyxO73n2M1zZfejYw1KDrFobEH/2Tmvj/fCwM1TG4lM02be gorg25kAyvs7Mf4j/juFISM2+cDSLJBK6QpaoTlddvAqhdzF1vSJ9EeGrvYqKv/NWuQk UREoZ2CSIntjQdePln+zxm6wYqDyC4vzH9edxTPTLzewoDQ1X9heDQc7v5bKssQOKuXi h0ZA== X-Gm-Message-State: AJcUukeQXz2SOZmlAZC951wapFhjsGpugqnyT8qC3pPOjH8UcuxmJzcX DdDVIsH4QFUGnT5DFRZCEI50mA== X-Google-Smtp-Source: ALg8bN5oGX9gyw8krOS+5EjZFSffTaw+IjPqNFvK7H5kEv6hyAF1iLjxjcFYO7HilTym0QzJibdWYA== X-Received: by 2002:a17:902:c05:: with SMTP id 5mr22868193pls.155.1548697672110; Mon, 28 Jan 2019 09:47:52 -0800 (PST) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id 7sm51397661pfm.8.2019.01.28.09.47.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Jan 2019 09:47:51 -0800 (PST) Date: Mon, 28 Jan 2019 09:47:50 -0800 From: Matthias Kaehlcke To: Balakrishna Godavarthi Cc: marcel@holtmann.org, johan.hedberg@gmail.com, johan@kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v9 1/3] Bluetooth: hci_qca: use wait_until_sent() for power pulses Message-ID: <20190128174750.GG81583@google.com> References: <20190124120808.8275-1-bgodavar@codeaurora.org> <20190124120808.8275-2-bgodavar@codeaurora.org> <20190125011412.GE81583@google.com> <0fac93a13ee445569659075cf467ad4d@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0fac93a13ee445569659075cf467ad4d@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Mon, Jan 28, 2019 at 07:19:56PM +0530, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2019-01-25 06:44, Matthias Kaehlcke wrote: > > On Thu, Jan 24, 2019 at 05:38:06PM +0530, Balakrishna Godavarthi wrote: > > > wcn3990 requires a power pulse to turn ON/OFF along with > > > regulators. Sometimes we are observing the power pulses are sent > > > out with some time delay, due to queuing these commands. This is > > > causing synchronization issues with chip, which intern delay the > > > chip setup or may end up with communication issues. > > > > > > Signed-off-by: Balakrishna Godavarthi > > > --- > > > Changes in v9: > > > * Reverted to 100us sleep. > > > * used inline call msecs_to_jiffies() > > > > > > Changes in v8: > > > * Updated 1 second timeout instead of indefinite wait. > > > > > > Changes in v7: > > > * updated the wait time to 5 ms after sending power pulses. > > > > > > Changes in v6: > > > * added serdev_device_write_flush() in qca_send_power_pulse > > > instead during the power off pulse. > > > > > > Changes in v5: > > > * added serdev_device_write_flush() in qca_power_off(). > > > --- > > > drivers/bluetooth/hci_qca.c | 40 > > > +++++++++++++++---------------------- > > > 1 file changed, 16 insertions(+), 24 deletions(-) > > > > > > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c > > > index f036c8f98ea3..c08f4d105e73 100644 > > > --- a/drivers/bluetooth/hci_qca.c > > > +++ b/drivers/bluetooth/hci_qca.c > > > @@ -60,6 +60,7 @@ > > > #define IBS_WAKE_RETRANS_TIMEOUT_MS 100 > > > #define IBS_TX_IDLE_TIMEOUT_MS 2000 > > > #define BAUDRATE_SETTLE_TIMEOUT_MS 300 > > > +#define POWER_PULSE_TRANS_TIMEOUT_MS 1000 > > > > I still doubt that this mega-timeout of 1s is needed, but it shouldn't > > do any harm either, so whatever ... > > > > [Bala]: for now let us have it. we can improve it in the improvement patch > based on the results. Fine. With the UART buffer flushed and flow control disabled I wonder though what makes you think that it could take longer than a few milliseconds for the byte being put on the wire, short of a bug in the UART driver or hardware, which (if it existed) shouldn't be worked around here. > > > /* susclk rate */ > > > #define SUSCLK_RATE_32KHZ 32768 > > > @@ -1013,11 +1014,10 @@ static inline void host_set_baudrate(struct > > > hci_uart *hu, unsigned int speed) > > > hci_uart_set_baudrate(hu, speed); > > > } > > > > > > -static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd) > > > +static int qca_send_power_pulse(struct hci_uart *hu, u8 cmd) > > > { > > > - struct hci_uart *hu = hci_get_drvdata(hdev); > > > - struct qca_data *qca = hu->priv; > > > - struct sk_buff *skb; > > > + int ret; > > > + int timeout = msecs_to_jiffies(POWER_PULSE_TRANS_TIMEOUT_MS); > > > > > > /* These power pulses are single byte command which are sent > > > * at required baudrate to wcn3990. On wcn3990, we have an external > > > @@ -1029,21 +1029,19 @@ static int qca_send_power_pulse(struct > > > hci_dev *hdev, u8 cmd) > > > * save power. Disabling hardware flow control is mandatory while > > > * sending power pulses to SoC. > > > */ > > > - bt_dev_dbg(hdev, "sending power pulse %02x to SoC", cmd); > > > - > > > - skb = bt_skb_alloc(sizeof(cmd), GFP_KERNEL); > > > - if (!skb) > > > - return -ENOMEM; > > > + bt_dev_dbg(hu->hdev, "sending power pulse %02x to controller", cmd); > > > > > > + serdev_device_write_flush(hu->serdev); > > > hci_uart_set_flow_control(hu, true); > > > + ret = serdev_device_write_buf(hu->serdev, &cmd, sizeof(cmd)); > > > + if (ret < 0) { > > > + bt_dev_err(hu->hdev, "failed to send power pulse %02x", cmd); > > > + return ret; > > > + } > > > > > > - skb_put_u8(skb, cmd); > > > - hci_skb_pkt_type(skb) = HCI_COMMAND_PKT; > > > - > > > - skb_queue_tail(&qca->txq, skb); > > > - hci_uart_tx_wakeup(hu); > > > + serdev_device_wait_until_sent(hu->serdev, timeout); > > > > > > - /* Wait for 100 uS for SoC to settle down */ > > > + /* Wait for 100 uS for SoC to settle down for the received byte. */ > > > > I don't think 'for the received byte' adds much value here. If you > > respin anyway I'd suggest to leave the comment as is. > > > > [Bala]: will update. > > > > usleep_range(100, 200); > > > hci_uart_set_flow_control(hu, false); > > > > > > @@ -1116,7 +1114,6 @@ static int qca_set_speed(struct hci_uart *hu, > > > enum qca_speed_type speed_type) > > > > > > static int qca_wcn3990_init(struct hci_uart *hu) > > > { > > > - struct hci_dev *hdev = hu->hdev; > > > struct qca_serdev *qcadev; > > > int ret; > > > > > > @@ -1139,12 +1136,12 @@ static int qca_wcn3990_init(struct hci_uart > > > *hu) > > > > > > /* Forcefully enable wcn3990 to enter in to boot mode. */ > > > host_set_baudrate(hu, 2400); > > > - ret = qca_send_power_pulse(hdev, QCA_WCN3990_POWEROFF_PULSE); > > > + ret = qca_send_power_pulse(hu, QCA_WCN3990_POWEROFF_PULSE); > > > if (ret) > > > return ret; > > > > > > qca_set_speed(hu, QCA_INIT_SPEED); > > > - ret = qca_send_power_pulse(hdev, QCA_WCN3990_POWERON_PULSE); > > > + ret = qca_send_power_pulse(hu, QCA_WCN3990_POWERON_PULSE); > > > if (ret) > > > return ret; > > > > > > @@ -1274,13 +1271,8 @@ static const struct qca_vreg_data > > > qca_soc_data = { > > > > > > static void qca_power_shutdown(struct hci_uart *hu) > > > { > > > - struct serdev_device *serdev = hu->serdev; > > > - unsigned char cmd = QCA_WCN3990_POWEROFF_PULSE; > > > - > > > host_set_baudrate(hu, 2400); > > > - hci_uart_set_flow_control(hu, true); > > > - serdev_device_write_buf(serdev, &cmd, sizeof(cmd)); > > > - hci_uart_set_flow_control(hu, false); > > > + qca_send_power_pulse(hu, QCA_WCN3990_POWEROFF_PULSE); > > > qca_power_setup(hu, false); > > > } > > > > > > > Looks good to me besides possible minor improvements: > > > > Reviewed-by: Matthias Kaehlcke >