Re: [PATCH] tools/hcidump: Decode FastStream, aptX Low Latency, aptX HD and LDAC

["Pasi Kärkkäinen" <pasik@iki.fi>]

On Wed, Jan 23, 2019 at 06:54:48PM +0100, Pali Rohár wrote:
> On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
> > Hi Pali,
> > 
> > > ---
> > > tools/parser/avdtp.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++---
> > > 1 file changed, 55 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/tools/parser/avdtp.c b/tools/parser/avdtp.c
> > > index 18569c895..a21410f5a 100644
> > > --- a/tools/parser/avdtp.c
> > > +++ b/tools/parser/avdtp.c
> > > @@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec)
> > > {
> > > 	if (vendor == 0x0000004f && vndcodec == 0x0001)
> > > 		return "aptX";
> > > +	else if (vendor == 0x0000000a && vndcodec == 0x0001)
> > > +		return "FastStream";
> > > +	else if (vendor == 0x0000000a && vndcodec == 0x0002)
> > > +		return "aptX Low Latency";
> > > +	else if (vendor == 0x000000d7 && vndcodec == 0x0024)
> > > +		return "aptX HD";
> > > 	else if (vendor == 0x0000012d && vndcodec == 0x00aa)
> > > 		return "LDAC";
> > > 	return "Unknown???;
> > 
> > lets keep the focus on btmon support since nobody should be using hcidump anymore.
> 
> In btmon I already implemented it and patches are now merged. I just
> found another place where this capability parsing is implemented and
> based on fact that users still use hcidump I quickly looked at it and
> implemented this parsing.
> 

I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc),
so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.


> > Regards
> > 
> > Marcel
> > 
> 
> -- 
> Pali Rohár
> pali.rohar@gmail.com


-- Pasi