From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B6D2C43381 for ; Tue, 19 Feb 2019 19:06:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2975E2147C for ; Tue, 19 Feb 2019 19:06:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jwLt0N8f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729341AbfBSTGZ (ORCPT ); Tue, 19 Feb 2019 14:06:25 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:46399 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726610AbfBSTGZ (ORCPT ); Tue, 19 Feb 2019 14:06:25 -0500 Received: by mail-pl1-f193.google.com with SMTP id o6so10868303pls.13 for ; Tue, 19 Feb 2019 11:06:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=I4LcM2XBTrkfUUVyaeSdAN2dPlTfFQPTd7YEe6AD0zw=; b=jwLt0N8fNHdUwJdXOlSYTSlQ/1fyUotRs62f6sGjPZo/svxilSw2rroNDsQJjE7Az7 fcleijRl2Nch8HGAbgFT4Nwzsn4hzIcau3+sIPMK9r08ATUIkGVTqksfFs7BYCgLQk5x 1nwLx2wn6XiPPixZXxcoVZdQ9xcku/PosugqE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=I4LcM2XBTrkfUUVyaeSdAN2dPlTfFQPTd7YEe6AD0zw=; b=K9UfsLQpoEHkdan2nJRK6StukAY5c7d8aSdd3hYO03ocwHXzDi5Oe6W8Zxltsvn+OQ 1GjqO+r+ipVhuKL/fjKbj22al843sHmcZl+T+E3Ugv2Op7aRO+vBkqNMIqecSAa4/A6L bcKYxDu9L/j8aFMOpTB9OIRSPhSH9owGJhBuRsad2OQ5LiDn6OmHjbEYUPt4PamS09Gz Ne5lCg3bq6UEfPQVit2AlZ8Yb8cgD8O3iBlb/DLJg4Uc8FRl3f3XrugMJ4bNVhGQvaFG guLk7Aa9JP7UwC2FbLywNv1rh+sucTqpERdnXUjOZg4GdizF1eWH789gZYhps3lqcZP+ +OYQ== X-Gm-Message-State: AHQUAuZmJjnlcrFVEo80M7POqdpJonmstzUkAZ0vj70X84A/Oqr+w3mZ 5dvPe1/PnbgVQn/p55A4KbR2hw== X-Google-Smtp-Source: AHgI3IY6yq/EMfadrl0MmfNVvwCACvmtBhV57YHyZcEeoTEYGMvvCmQD0Xtuf+Z1/OtiHtfXzUA7Rw== X-Received: by 2002:a17:902:1e8:: with SMTP id b95mr32109887plb.325.1550603184871; Tue, 19 Feb 2019 11:06:24 -0800 (PST) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id n85sm5092156pfj.177.2019.02.19.11.06.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Feb 2019 11:06:24 -0800 (PST) Date: Tue, 19 Feb 2019 11:06:23 -0800 From: Matthias Kaehlcke To: Marcel Holtmann Cc: Johan Hedberg , "David S. Miller" , Loic Poulain , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Balakrishna Godavarthi Subject: Re: [PATCH RESEND 0/3] Add quirk for reading BD_ADDR from fwnode property Message-ID: <20190219190623.GA116191@google.com> References: <20190131221021.176809-1-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Marcel, On Mon, Feb 18, 2019 at 11:48:21AM +0100, Marcel Holtmann wrote: > Hi Matthias, > > > [initial post: https://lore.kernel.org/patchwork/cover/1028184/] > > > > On some systems the Bluetooth Device Address (BD_ADDR) isn't stored > > on the Bluetooth chip itself. One way to configure the address is > > through the device tree (patched in by the bootloader). The btqcomsmd > > driver is an example, it can read the address from the DT property > > 'local-bd-address'. > > > > To avoid redundant open-coded reading of 'local-bd-address' and error > > handling this series adds the quirk HCI_QUIRK_USE_BDADDR_PROPERTY to > > retrieve the BD address of a device from the DT and adapts the > > btqcomsmd and hci_qca drivers to use this quirk. > > > > Matthias Kaehlcke (3): > > Bluetooth: Add quirk for reading BD_ADDR from fwnode property > > Bluetooth: btqcomsmd: use HCI_QUIRK_USE_BDADDR_PROPERTY > > Bluetooth: hci_qca: Set HCI_QUIRK_USE_BDADDR_PROPERTY for wcn3990 > > > > drivers/bluetooth/btqcomsmd.c | 29 +++-------------------- > > drivers/bluetooth/hci_qca.c | 1 + > > include/net/bluetooth/hci.h | 12 ++++++++++ > > net/bluetooth/hci_core.c | 43 +++++++++++++++++++++++++++++++++++ > > net/bluetooth/mgmt.c | 6 +++-- > > 5 files changed, 63 insertions(+), 28 deletions(-) > > I am getting compiler warnings when trying to apply this set: > > CC drivers/bluetooth/btqcomsmd.o > drivers/bluetooth/btqcomsmd.c: In function ‘btqcomsmd_setup’: > drivers/bluetooth/btqcomsmd.c:120:6: warning: unused variable ‘err’ [-Wunused-variable] > int err; > ^~~ > drivers/bluetooth/btqcomsmd.c:118:20: warning: unused variable ‘btq’ [-Wunused-variable] > struct btqcomsmd *btq = hci_get_drvdata(hdev); > ^~~ Sorry, I missed that the variables aren't used anymore. I'll send a new version soon. Thanks Matthias