From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 450E1C43381 for ; Sun, 24 Feb 2019 13:19:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 138C5206B6 for ; Sun, 24 Feb 2019 13:19:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728172AbfBXNTL (ORCPT ); Sun, 24 Feb 2019 08:19:11 -0500 Received: from emh03.mail.saunalahti.fi ([62.142.5.109]:39206 "EHLO emh03.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728059AbfBXNTL (ORCPT ); Sun, 24 Feb 2019 08:19:11 -0500 Received: from ydin.reaktio.net (reaktio.net [85.76.255.15]) by emh03.mail.saunalahti.fi (Postfix) with ESMTP id 630F6400F8; Sun, 24 Feb 2019 15:19:08 +0200 (EET) Received: by ydin.reaktio.net (Postfix, from userid 1001) id 9D8EC36C0F6; Sun, 24 Feb 2019 15:19:07 +0200 (EET) Date: Sun, 24 Feb 2019 15:19:07 +0200 From: Pasi =?iso-8859-1?Q?K=E4rkk=E4inen?= To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Luiz Augusto von Dentz , Marcel Holtmann , "linux-bluetooth@vger.kernel.org" Subject: Re: [PATCH] tools/hcidump: Decode FastStream, aptX Low Latency, aptX HD and LDAC Message-ID: <20190224131907.GV32745@reaktio.net> References: <20190123174504.12350-1-pali.rohar@gmail.com> <8D9BABBE-2BBC-4BFE-BF7C-3BE24AF4DD10@holtmann.org> <20190123175448.cdkdpnk6i5r4rzjs@pali> <20190130081517.GI32745@reaktio.net> <20190130120631.usx67zjk4kmbhcla@pali> <20190201124353.GK32745@reaktio.net> <20190206114300.rxw3ptq7hzathzqe@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190206114300.rxw3ptq7hzathzqe@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Wed, Feb 06, 2019 at 12:43:00PM +0100, Pali Rohár wrote: > On Friday 01 February 2019 14:43:53 Pasi Kärkkäinen wrote: > > Hi, > > > > On Wed, Jan 30, 2019 at 02:24:11PM +0200, Luiz Augusto von Dentz wrote: > > > Hi Pali, Pasi, > > > On Wed, Jan 30, 2019 at 2:09 PM Pali Rohár wrote: > > > > > > > > On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote: > > > > > On Wed, Jan 23, 2019 at 06:54:48PM +0100, Pali Rohár wrote: > > > > > > On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote: > > > > > > > Hi Pali, > > > > > > > > > > > > > > > --- > > > > > > > > tools/parser/avdtp.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++--- > > > > > > > > 1 file changed, 55 insertions(+), 3 deletions(-) > > > > > > > > > > > > > > > > diff --git a/tools/parser/avdtp.c b/tools/parser/avdtp.c > > > > > > > > index 18569c895..a21410f5a 100644 > > > > > > > > --- a/tools/parser/avdtp.c > > > > > > > > +++ b/tools/parser/avdtp.c > > > > > > > > @@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec) > > > > > > > > { > > > > > > > > if (vendor == 0x0000004f && vndcodec == 0x0001) > > > > > > > > return "aptX"; > > > > > > > > + else if (vendor == 0x0000000a && vndcodec == 0x0001) > > > > > > > > + return "FastStream"; > > > > > > > > + else if (vendor == 0x0000000a && vndcodec == 0x0002) > > > > > > > > + return "aptX Low Latency"; > > > > > > > > + else if (vendor == 0x000000d7 && vndcodec == 0x0024) > > > > > > > > + return "aptX HD"; > > > > > > > > else if (vendor == 0x0000012d && vndcodec == 0x00aa) > > > > > > > > return "LDAC"; > > > > > > > > return "Unknown???; > > > > > > > > > > > > > > lets keep the focus on btmon support since nobody should be using hcidump anymore. > > > > > > > > > > > > In btmon I already implemented it and patches are now merged. I just > > > > > > found another place where this capability parsing is implemented and > > > > > > based on fact that users still use hcidump I quickly looked at it and > > > > > > implemented this parsing. > > > > > > > > > > > > > > > > I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc), > > > > > so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small. > > > > > > > > Exactly, people still use hcidump... > > > > > > Well it is a deprecated tool which we might remove starting on BlueZ > > > 6.x which we would like to do in the very next release, if that > > > doesn't happen than perhaps Id take these patches in for a very last > > > BlueZ 5.x release. > > > > > > @Marcel: Or you have a better plan? We could do one last 5.x and then > > > start working on removing the deprecated tools/etc. > > > > > > > +1 for doing one last 5.x release before deprecating and removing tools etc! > > Ok, what is the plan? If hcidump is not going to be deleted in upcoming > release, can you take this patch? > How about applying this patch now, considering it's small, and has value for anyone using hcidump. hcidump then gets removed later whenever the removal of deprecated features/tools starts. Any news about next bluez release? > -- > Pali Rohár > pali.rohar@gmail.com Thanks, -- Pasi