From: "Pali Rohár" <pali.rohar@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: "Pasi Kärkkäinen" <pasik@iki.fi>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] tools/hcidump: Decode FastStream, aptX Low Latency, aptX HD and LDAC
Date: Wed, 10 Apr 2019 10:29:24 +0200 [thread overview]
Message-ID: <20190410082924.exo2oihzd7w2oz3e@pali> (raw)
In-Reply-To: <20190305122630.gwnaz3y7ckzqfjfq@pali>
On Tuesday 05 March 2019 13:26:30 Pali Rohár wrote:
> On Sunday 24 February 2019 15:19:07 Pasi Kärkkäinen wrote:
> > On Wed, Feb 06, 2019 at 12:43:00PM +0100, Pali Rohár wrote:
> > > On Friday 01 February 2019 14:43:53 Pasi Kärkkäinen wrote:
> > > > Hi,
> > > >
> > > > On Wed, Jan 30, 2019 at 02:24:11PM +0200, Luiz Augusto von Dentz wrote:
> > > > > Hi Pali, Pasi,
> > > > > On Wed, Jan 30, 2019 at 2:09 PM Pali Rohár <pali.rohar@gmail.com> wrote:
> > > > > >
> > > > > > On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
> > > > > > > On Wed, Jan 23, 2019 at 06:54:48PM +0100, Pali Rohár wrote:
> > > > > > > > On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
> > > > > > > > > Hi Pali,
> > > > > > > > >
> > > > > > > > > > ---
> > > > > > > > > > tools/parser/avdtp.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++---
> > > > > > > > > > 1 file changed, 55 insertions(+), 3 deletions(-)
> > > > > > > > > >
> > > > > > > > > > diff --git a/tools/parser/avdtp.c b/tools/parser/avdtp.c
> > > > > > > > > > index 18569c895..a21410f5a 100644
> > > > > > > > > > --- a/tools/parser/avdtp.c
> > > > > > > > > > +++ b/tools/parser/avdtp.c
> > > > > > > > > > @@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec)
> > > > > > > > > > {
> > > > > > > > > > if (vendor == 0x0000004f && vndcodec == 0x0001)
> > > > > > > > > > return "aptX";
> > > > > > > > > > + else if (vendor == 0x0000000a && vndcodec == 0x0001)
> > > > > > > > > > + return "FastStream";
> > > > > > > > > > + else if (vendor == 0x0000000a && vndcodec == 0x0002)
> > > > > > > > > > + return "aptX Low Latency";
> > > > > > > > > > + else if (vendor == 0x000000d7 && vndcodec == 0x0024)
> > > > > > > > > > + return "aptX HD";
> > > > > > > > > > else if (vendor == 0x0000012d && vndcodec == 0x00aa)
> > > > > > > > > > return "LDAC";
> > > > > > > > > > return "Unknown???;
> > > > > > > > >
> > > > > > > > > lets keep the focus on btmon support since nobody should be using hcidump anymore.
> > > > > > > >
> > > > > > > > In btmon I already implemented it and patches are now merged. I just
> > > > > > > > found another place where this capability parsing is implemented and
> > > > > > > > based on fact that users still use hcidump I quickly looked at it and
> > > > > > > > implemented this parsing.
> > > > > > > >
> > > > > > >
> > > > > > > I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc),
> > > > > > > so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.
> > > > > >
> > > > > > Exactly, people still use hcidump...
> > > > >
> > > > > Well it is a deprecated tool which we might remove starting on BlueZ
> > > > > 6.x which we would like to do in the very next release, if that
> > > > > doesn't happen than perhaps Id take these patches in for a very last
> > > > > BlueZ 5.x release.
> > > > >
> > > > > @Marcel: Or you have a better plan? We could do one last 5.x and then
> > > > > start working on removing the deprecated tools/etc.
> > > > >
> > > >
> > > > +1 for doing one last 5.x release before deprecating and removing tools etc!
> > >
> > > Ok, what is the plan? If hcidump is not going to be deleted in upcoming
> > > release, can you take this patch?
> > >
> >
> > How about applying this patch now, considering it's small, and has value for anyone using hcidump.
> > hcidump then gets removed later whenever the removal of deprecated features/tools starts.
>
> So... what are plans for next release?
Marcel, Luiz, can you comment next steps? It is waiting there for your
info here for more than 2 months.
> > Any news about next bluez release?
> >
> >
> >
> > > --
> > > Pali Rohár
> > > pali.rohar@gmail.com
> >
> >
> > Thanks,
> >
> > -- Pasi
> >
>
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2019-04-10 8:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 17:45 [PATCH] tools/hcidump: Decode FastStream, aptX Low Latency, aptX HD and LDAC Pali Rohár
2019-01-23 17:46 ` Marcel Holtmann
2019-01-23 17:54 ` Pali Rohár
2019-01-30 8:15 ` Pasi Kärkkäinen
2019-01-30 12:06 ` Pali Rohár
2019-01-30 12:24 ` Luiz Augusto von Dentz
2019-02-01 12:43 ` Pasi Kärkkäinen
2019-02-06 11:43 ` Pali Rohár
2019-02-24 13:19 ` Pasi Kärkkäinen
2019-03-05 12:26 ` Pali Rohár
2019-04-10 8:29 ` Pali Rohár [this message]
2019-06-07 13:07 ` Pali Rohár
2019-10-14 11:07 ` Pali Rohár
2020-02-09 13:05 ` Pali Rohár
2020-04-14 23:00 ` Pali Rohár
2020-05-03 11:14 ` Pali Rohár
2020-08-08 13:24 ` Pali Rohár
2020-09-29 21:34 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410082924.exo2oihzd7w2oz3e@pali \
--to=pali.rohar@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=pasik@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).