From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ] shared/gatt-client: Automatically add CCC when discovering
Date: Mon, 26 Aug 2019 15:06:13 +0300 [thread overview]
Message-ID: <20190826120613.23233-1-luiz.dentz@gmail.com> (raw)
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
The spec mandates that a CCC exists if either notify or indicate
property is marked:
BLUETOOTH CORE SPECIFICATION Version 5.1 | Vol 3, Part G page 2357
"If set, the Client Characteristic Configuration Descriptor shall
exist."
---
src/shared/gatt-client.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/src/shared/gatt-client.c b/src/shared/gatt-client.c
index 225915d43..38a416ed3 100644
--- a/src/shared/gatt-client.c
+++ b/src/shared/gatt-client.c
@@ -659,6 +659,31 @@ static bool discover_descs(struct discovery_op *op, bool *discovering)
desc_start = chrc_data->value_handle + 1;
+ if (desc_start == chrc_data->end_handle &&
+ (chrc_data->properties & BT_GATT_CHRC_PROP_NOTIFY ||
+ chrc_data->properties & BT_GATT_CHRC_PROP_INDICATE)) {
+ bt_uuid_t ccc_uuid;
+
+ /* If there is only one descriptor that must be the CCC
+ * in case either notify or indicate are supported.
+ */
+ bt_uuid16_create(&ccc_uuid,
+ GATT_CLIENT_CHARAC_CFG_UUID);
+ attr = gatt_db_insert_descriptor(client->db, desc_start,
+ &ccc_uuid, 0, NULL,
+ NULL, NULL);
+ if (attr) {
+ free(chrc_data);
+ continue;
+ }
+ }
+
+ /* Check if the start range is within characteristic range */
+ if (desc_start > chrc_data->end_handle) {
+ free(chrc_data);
+ continue;
+ }
+
client->discovery_req = bt_gatt_discover_descriptors(
client->att, desc_start,
chrc_data->end_handle,
--
2.21.0
next reply other threads:[~2019-08-26 12:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 12:06 Luiz Augusto von Dentz [this message]
2019-09-06 8:14 ` [PATCH BlueZ] shared/gatt-client: Automatically add CCC when discovering Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826120613.23233-1-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).