From: Michal Suchanek <msuchanek@suse.de>
To: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org
Cc: Michal Suchanek <msuchanek@suse.de>,
linux-kernel@vger.kernel.org, oneukum@suse.com, acho@suse.com,
tiwai@suse.com, jlee@suse.com
Subject: [PATCH] Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature"
Date: Wed, 28 Aug 2019 14:13:49 +0200 [thread overview]
Message-ID: <20190828121349.24966-1-msuchanek@suse.de> (raw)
This reverts commit a0085f2510e8976614ad8f766b209448b385492f.
After this commit systems wake up at random, most commonly when
- put to sleep while bluetooth audio stream is running
- connected bluetooth audio device is powered off while system is
asleep
This is broken since the commit was merged up to 5.3-rc6.
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
drivers/bluetooth/btusb.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 5cf0734eb31b..5c67d41ca254 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -1170,10 +1170,6 @@ static int btusb_open(struct hci_dev *hdev)
}
data->intf->needs_remote_wakeup = 1;
- /* device specific wakeup source enabled and required for USB
- * remote wakeup while host is suspended
- */
- device_wakeup_enable(&data->udev->dev);
if (test_and_set_bit(BTUSB_INTR_RUNNING, &data->flags))
goto done;
@@ -1238,7 +1234,6 @@ static int btusb_close(struct hci_dev *hdev)
goto failed;
data->intf->needs_remote_wakeup = 0;
- device_wakeup_disable(&data->udev->dev);
usb_autopm_put_interface(data->intf);
failed:
--
2.22.0
next reply other threads:[~2019-08-28 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 12:13 Michal Suchanek [this message]
2019-08-30 7:49 ` [PATCH] Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature" Marcel Holtmann
2019-08-30 9:34 ` Michal Suchánek
-- strict thread matches above, loose matches on Subject: below --
2019-08-19 17:04 Mario Limonciello
2019-08-30 7:46 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828121349.24966-1-msuchanek@suse.de \
--to=msuchanek@suse.de \
--cc=acho@suse.com \
--cc=jlee@suse.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=oneukum@suse.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).