From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87D1DC43331 for ; Thu, 7 Nov 2019 23:27:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F4BA2178F for ; Thu, 7 Nov 2019 23:27:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="G9f2QFqb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727164AbfKGX1q (ORCPT ); Thu, 7 Nov 2019 18:27:46 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:37330 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbfKGX1p (ORCPT ); Thu, 7 Nov 2019 18:27:45 -0500 Received: by mail-pl1-f193.google.com with SMTP id p13so2701543pll.4 for ; Thu, 07 Nov 2019 15:27:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7BmFIfu3M0HZwt+Q5j2ru4f7l0bIsWe0OLM9WwddihI=; b=G9f2QFqbIpvPzP+ipqv0GmvyF0eGXGh9QMSFOoyB9+jjACRbO5OOZS7NIVxmaNMytG n07iwrwawUQCkkQ+h2iJuX5tvkGdmj+06phZZtSy00G6NxWK5tA+YY4fFcpBzQ/aoZvN vS+ECTdz67UOybb5+svMppyxtzMa3RqNcmQEY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7BmFIfu3M0HZwt+Q5j2ru4f7l0bIsWe0OLM9WwddihI=; b=Qvl/cAvAspvZTaeosSv3pgHI8mpsbDIKy5Ta+6ZAxpUR1OxuYxoHBpwwDCcGuPc7AZ c53lfnjQKbTLnsrts1RgRqeBc9avfGFzAWdMGG2QY5mmYlnlqEgsfrGT30EKQ2pc6QwX Ioe7cjrENIwRtTHWWveznoXeVqrIeCTq3D5WYYOONNU5Y4DjRaitzl7lCcsGCPGFXX0M Mj/gNTqc9+1uDVltVTngrmSJ7m6sDZueDMcvJ9VIJo6/51i5Oqq4XmeNXg2a9GPRLlyk 7ki0wYqbZn3KsF9NjRZmcy/70KRkqLLqMWqyNC1ksNDdoLeTjQPfzX4XbxlnspkRUjfR xTGQ== X-Gm-Message-State: APjAAAVME2c/fB9vmHQcgRHqmnrSsIExJyKhCAthL0Ac7/EKezh/o9v6 0dBfZ/IwZ7U8PxWlVF4R+dxYHg== X-Google-Smtp-Source: APXvYqwZ3sdkT/3KJlMbe4Hd1YyUWULxtkb2dkHIZqIJTqrSJI3u9TYS9VmzJM4iV2SkR6u0xQOIyQ== X-Received: by 2002:a17:902:9002:: with SMTP id a2mr6824143plp.133.1573169264975; Thu, 07 Nov 2019 15:27:44 -0800 (PST) Received: from apsdesk.mtv.corp.google.com ([2620:15c:202:1:e09a:8d06:a338:aafb]) by smtp.gmail.com with ESMTPSA id h3sm2857579pji.16.2019.11.07.15.27.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2019 15:27:44 -0800 (PST) From: Abhishek Pandit-Subedi To: Marcel Holtmann , Johan Hedberg , Rob Herring Cc: linux-bluetooth@vger.kernel.org, dianders@chromium.org, Abhishek Pandit-Subedi , devicetree@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ondrej Jirman , Mark Rutland , Chen-Yu Tsai Subject: [PATCH v2 0/4] Bluetooth: hci_bcm: Additional changes for BCM4354 support Date: Thu, 7 Nov 2019 15:27:08 -0800 Message-Id: <20191107232713.48577-1-abhishekpandit@chromium.org> X-Mailer: git-send-email 2.24.0.rc1.363.gb1bccd3e3d-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org While adding support for the BCM4354, I discovered a few more things that weren't working as they should have. First, we disallow serdev from setting the baudrate on BCM4354. Serdev sets the oper_speed first before calling hu->setup() in hci_uart_setup(). On the BCM4354, this results in bcm_setup() failing when the hci reset times out. Next, we add support for setting the PCM parameters, which consists of a pair of vendor specific opcodes to set the pcm parameters. The documentation for these params are available in the brcm_patchram_plus package (i.e. https://github.com/balena-os/brcm_patchram_plus). This is necessary for PCM to work properly. All changes were tested with rk3288-veyron-minnie.dts. Changes in v2: - Use match data to disallow baudrate setting - Parse pcm parameters by name instead of as a byte string - Fix prefix for dt-bindings commit Abhishek Pandit-Subedi (4): Bluetooth: hci_bcm: Disallow set_baudrate for BCM4354 Bluetooth: btbcm: Support pcm configuration Bluetooth: hci_bcm: Support pcm params in dts dt-bindings: net: broadcom-bluetooth: Add pcm config .../bindings/net/broadcom-bluetooth.txt | 11 ++++ drivers/bluetooth/btbcm.c | 35 +++++++++++ drivers/bluetooth/btbcm.h | 10 ++++ drivers/bluetooth/hci_bcm.c | 58 ++++++++++++++++++- 4 files changed, 112 insertions(+), 2 deletions(-) -- 2.24.0.rc1.363.gb1bccd3e3d-goog