From: Simon Horman <simon.horman@netronome.com>
To: Colin King <colin.king@canonical.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: remove redundant assignment to variable icid
Date: Wed, 8 Jan 2020 14:57:28 +0100 [thread overview]
Message-ID: <20200108135728.GA19220@netronome.com> (raw)
In-Reply-To: <20200107180013.124501-1-colin.king@canonical.com>
On Tue, Jan 07, 2020 at 06:00:13PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable icid is being rc is assigned with a value that is never
> read. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
> ---
> net/bluetooth/l2cap_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index 1bca608e0170..195459a1e53e 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -5081,7 +5081,6 @@ static inline int l2cap_move_channel_req(struct l2cap_conn *conn,
> chan->move_role = L2CAP_MOVE_ROLE_RESPONDER;
> l2cap_move_setup(chan);
> chan->move_id = req->dest_amp_id;
> - icid = chan->dcid;
>
> if (req->dest_amp_id == AMP_ID_BREDR) {
> /* Moving to BR/EDR */
> --
> 2.24.0
>
next prev parent reply other threads:[~2020-01-08 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 18:00 [PATCH] Bluetooth: remove redundant assignment to variable icid Colin King
2020-01-08 13:57 ` Simon Horman [this message]
2020-01-08 20:45 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108135728.GA19220@netronome.com \
--to=simon.horman@netronome.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).