From: "michal.lowas-rzechonek@silvair.com" <michal.lowas-rzechonek@silvair.com>
To: "Gix, Brian" <brian.gix@intel.com>
Cc: "istotlan@ingas-xps13.amr.corp.intel.com"
<istotlan@ingas-xps13.amr.corp.intel.com>,
"jakub.witowski@silvair.com" <jakub.witowski@silvair.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 0/1] Sequence number out of range fix
Date: Wed, 15 Jan 2020 23:02:39 +0100 [thread overview]
Message-ID: <20200115220239.x3jnpn5z6strqwr4@kynes> (raw)
In-Reply-To: <456a42fe1d521b9c61bb54bacbddf7b99573df5f.camel@intel.com>
On 01/15, Gix, Brian wrote:
> > Now, this raw value is used in send_seg, passed to
> > mesh_crypto_packet_build, which effectively applies a 24bit mask in line
> > 640:
>
> Yes, we should definitely be sanity checking this, and not sending if
> SeqNum out of range.
Ok, we'll do that then.
> I think if we are repeatedly crashing, and it is causing a runaway
> sequence number increase, that being forbidden to send more packets is
> a natural consequence, and people should fix the code that was causing
> the crash in the first place.
You don't say. But it's not a given that the code is in the daemon
itself. Two words: OOM killer.
--
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND
prev parent reply other threads:[~2020-01-15 22:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 17:08 [PATCH 0/1] Sequence number out of range fix Jakub Witowski
2020-01-15 17:08 ` [PATCH 1/1] mesh: sequence " Jakub Witowski
2020-01-15 18:35 ` [PATCH 0/1] Sequence " Gix, Brian
2020-01-15 19:09 ` michal.lowas-rzechonek
2020-01-15 19:53 ` Gix, Brian
2020-01-15 21:04 ` michal.lowas-rzechonek
2020-01-15 21:21 ` Gix, Brian
2020-01-15 22:02 ` michal.lowas-rzechonek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115220239.x3jnpn5z6strqwr4@kynes \
--to=michal.lowas-rzechonek@silvair.com \
--cc=brian.gix@intel.com \
--cc=istotlan@ingas-xps13.amr.corp.intel.com \
--cc=jakub.witowski@silvair.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).