From: "Michał Lowas-Rzechonek" <michal.lowas-rzechonek@silvair.com>
To: linux-bluetooth@vger.kernel.org
Cc: brian.gix@intel.com, inga.stotland@intel.com
Subject: Re: [RFC BlueZ 0/2] Fix types and names of beacon/import flags.
Date: Tue, 21 Jan 2020 21:15:01 +0100 [thread overview]
Message-ID: <20200121201501.v4ceigg5xngfvjb4@kynes> (raw)
In-Reply-To: <20200109083855.16000-1-michal.lowas-rzechonek@silvair.com>
Hi Brian, Inga,
On 01/09, Michał Lowas-Rzechonek wrote:
> This patchset aims to make the API a bit more consistent.
>
> Side question: at the moment none of the node properties emit
> PropertiesChanged signal. I think this violates D-Bus spec, since all
> properties are assumed to emit these signals by default [1] [2].
>
> Unfortunately, at the moment ELL does not support "EmitsChangedSignal"
> annotation, so I'd like to add this to ELL, annotate node
> properties with:
> - Features: const
> - Beacon: true
> - BeaconFlags: true
> - IvIndex: true
> - SecondsSinceLastHeard: false (for performance reasons)
> - Addresses: const
>
> And also emit PropertiesChanged where required.
>
> Thoughts?
Any comments about this idea, or should I just go ahead and send a
patch?
--
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND
next prev parent reply other threads:[~2020-01-21 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 8:38 [RFC BlueZ 0/2] Fix types and names of beacon/import flags Michał Lowas-Rzechonek
2020-01-09 8:38 ` [RFC BlueZ 1/2] mesh: Rename IVUpdate import flag to IvUpdate Michał Lowas-Rzechonek
2020-01-09 8:38 ` [RFC BlueZ 2/2] mesh: Change BeaconFlags property type to a dict Michał Lowas-Rzechonek
2020-01-21 20:15 ` Michał Lowas-Rzechonek [this message]
2020-01-22 0:44 ` [RFC BlueZ 0/2] Fix types and names of beacon/import flags Stotland, Inga
2020-01-22 1:14 ` Gix, Brian
2020-01-22 17:13 ` michal.lowas-rzechonek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121201501.v4ceigg5xngfvjb4@kynes \
--to=michal.lowas-rzechonek@silvair.com \
--cc=brian.gix@intel.com \
--cc=inga.stotland@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).