From: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
To: marcel@holtmann.org, linux-bluetooth@vger.kernel.org
Cc: chromeos-bluetooth-upstreaming@chromium.org,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
"David S. Miller" <davem@davemloft.net>,
Johan Hedberg <johan.hedberg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH 0/1] Bluetooth: Prioritize sco traffic on slow interfaces
Date: Thu, 12 Mar 2020 11:10:54 -0700 [thread overview]
Message-ID: <20200312181055.94038-1-abhishekpandit@chromium.org> (raw)
Hi linux-bluetooth,
While investigating supporting Voice over HCI/UART, we discovered that
it is possible for SCO packet deadlines to be missed in some conditions
where large ACL packets are being transferred. For UART, at a baudrate
of 3000000, a single 1024 byte packet will take ~3.4ms to transfer.
Sending two ACL packets of max size would cause us to miss the timing
for SCO (which is 3.75ms) in the worst case.
To mitigate this, we change hci_tx_work to prefer scheduling SCO/eSCO
over ACL/LE and modify the hci_sched_{acl,le} routines so that they will
only send one packet before checking whether a SCO packet is queued. ACL
packets should still get sent at a similar rate (depending on number of
ACL packets supported by controller) since the loop will continue until
there is no more quota left for ACL and LE packets.
To test this patch, I played some music over SCO (open youtube and
a video conference page at the same time) while using an LE keyboard.
There were no discernible slowdowns caused by this change.
Thanks
Abhishek
Abhishek Pandit-Subedi (1):
Bluetooth: Prioritize SCO traffic on slow interfaces
include/net/bluetooth/hci_core.h | 1 +
net/bluetooth/hci_core.c | 91 +++++++++++++++++++++++++-------
2 files changed, 73 insertions(+), 19 deletions(-)
--
2.25.1.481.gfbce0eb801-goog
next reply other threads:[~2020-03-12 18:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 18:10 Abhishek Pandit-Subedi [this message]
2020-03-12 18:10 ` [PATCH 1/1] Bluetooth: Prioritize SCO traffic on slow interfaces Abhishek Pandit-Subedi
2020-03-13 19:01 ` Marcel Holtmann
2020-03-14 0:30 ` Abhishek Pandit-Subedi
2020-03-18 17:11 ` Marcel Holtmann
2020-03-18 17:45 ` Abhishek Pandit-Subedi
2020-03-18 19:44 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312181055.94038-1-abhishekpandit@chromium.org \
--to=abhishekpandit@chromium.org \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).