From: Archie Pusaka <apusaka@google.com>
To: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Michael Sun <michaelfsun@google.com>,
Archie Pusaka <apusaka@chromium.org>
Subject: [Bluez PATCH v2] audio/avrcp: Fix media player passthrough bitmask
Date: Thu, 28 May 2020 14:46:21 +0800 [thread overview]
Message-ID: <20200528144605.Bluez.v2.1.Idd38f20f6ff4fc0b295a0a4a8655079373216933@changeid> (raw)
From: Archie Pusaka <apusaka@chromium.org>
Adjust the values of the passthrough bitmask with the declared
keys in avctp.c:key_map, according to section 6.10.2.1 of the
AVRCP specification.
---
Changes in v2:
- Fix the mix-up between the first 4 and the last 4 bits of each
octet
profiles/audio/avrcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index 773ccdb60..6c529bf0c 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -298,8 +298,8 @@ static unsigned int avctp_id = 0;
/* Default feature bit mask for media player as per avctp.c:key_map */
static const uint8_t features[16] = {
- 0xF8, 0xBF, 0xFF, 0xBF, 0x1F,
- 0xFB, 0x3F, 0x60, 0x00, 0x00,
+ 0x1F, 0xFA, 0xFF, 0xBB, 0xF3,
+ 0xBF, 0xF9, 0x06, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00,
0x00 };
--
2.27.0.rc2.251.g90737beb825-goog
next reply other threads:[~2020-05-28 6:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 6:46 Archie Pusaka [this message]
2020-05-28 16:03 ` [Bluez PATCH v2] audio/avrcp: Fix media player passthrough bitmask Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528144605.Bluez.v2.1.Idd38f20f6ff4fc0b295a0a4a8655079373216933@changeid \
--to=apusaka@google.com \
--cc=apusaka@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=michaelfsun@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).