From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH v3 2/2] avrcp: Don't attempt to load settings if on volume changed is supported
Date: Thu, 28 May 2020 14:53:00 -0700 [thread overview]
Message-ID: <20200528215300.225894-2-luiz.dentz@gmail.com> (raw)
In-Reply-To: <20200528215300.225894-1-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
If only volume changed is supported that means the player cannot really
indicate track/metadata changes so don't attempt to read them.
---
profiles/audio/avrcp.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index 75811bf98..8b3debe46 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -3814,6 +3814,10 @@ static gboolean avrcp_get_capabilities_resp(struct avctp *conn, uint8_t code,
if (!session->controller || !session->controller->player)
return FALSE;
+ /* Skip if player status/metadata if only volume changes is supported */
+ if (events == (1 << AVRCP_EVENT_VOLUME_CHANGED))
+ return FALSE;
+
if ((session->controller->features & AVRCP_FEATURE_PLAYER_SETTINGS) &&
!(events & (1 << AVRCP_EVENT_SETTINGS_CHANGED)))
avrcp_list_player_attributes(session);
--
2.25.3
next prev parent reply other threads:[~2020-05-28 21:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 21:52 [PATCH v3 1/2] avrcp: Fix always requesting player settings for category 1 Luiz Augusto von Dentz
2020-05-28 21:53 ` Luiz Augusto von Dentz [this message]
2020-05-28 23:10 ` [PATCH v3 2/2] avrcp: Don't attempt to load settings if on volume changed is supported Andrey Semashev
2020-05-29 20:29 ` [PATCH v3 1/2] avrcp: Fix always requesting player settings for category 1 Luiz Augusto von Dentz
2020-05-29 20:56 ` Andrey Semashev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528215300.225894-2-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).