Linux-Bluetooth Archive on
 help / color / Atom feed
From: "Pali Rohár" <>
To: Yu Liu <>
Cc:, Hsin-Yu Chao <>,
	Sonny Sasaka <>
Subject: Re: [Bluez PATCH v1] device - If HFP is supported, ignore HSP
Date: Fri, 3 Jul 2020 12:15:43 +0200
Message-ID: <20200703101543.nrkpczji7zasqueg@pali> (raw)
In-Reply-To: <20200630154855.Bluez.v1.1.I63c3ddd54189c2ad9ca9aba2c08e0925d7f0aee3@changeid>

On Tuesday 30 June 2020 15:49:34 Yu Liu wrote:
> From: Hsin-Yu Chao <>
> For a BT headset that supports both HSP and HFP, BlueZ creates
> service instances for these two profiles and connects them.
> It's uncertain that which of HSP and HFP eventually get connected
> and being used for SCO audio. And we start observing some problem
> because of this uncertainty:
> - For headset that supports WBS, we need HFP connect for codec
> negotiation. If HSP connects but not HFP, WBS cannot be used.
> - For WH-1000XM3, if BlueZ ever initiated HFP connection but failed,
> headset won't have working SCO audio even HSP is connected.
> Fix this at when device probes services, if HFP is in the uuid list,
> don't bother create one for HSP.
> Reviewed-by: Sonny Sasaka <>
> ---
> Changes in v1:
> - Initial change
>  src/device.c | 5 +++++
>  1 file changed, 5 insertions(+)
> diff --git a/src/device.c b/src/device.c
> index 7b0eb256e..4036bfd81 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -4370,6 +4370,11 @@ static struct btd_service *probe_service(struct btd_device *device,
>  	if (!device_match_profile(device, profile, uuids))
>  		return NULL;
> +	/* If device supports HFP, don't bother create service for HSP. */
> +	if (g_slist_find_custom(uuids, HFP_HS_UUID, bt_uuid_strcmp) &&
> +		bt_uuid_strcmp(profile->remote_uuid, HSP_HS_UUID) == 0)
> +		return NULL;
> +

This patch would completely break devices with buggy HFP profile

Also this patch disallow usage of HSP when both HSP and HFP are

I'm against this change as it disallow to use HSP and HFP simultaneously
with hsphpfd daemon. With hsphfpd daemon it is working with non-buggy

Also in pulseaudio we have more bug reports that HFP is does not work
(even when advertised), but HSP is working fine.

If you have a broken headset as you described in commit message, then
please add some quirk for it. But do not disallow usage of HSP / HFP for
all devices including non-broken ones, just because you have one broken

>  	l = find_service_with_profile(device->services, profile);
>  	if (l)
>  		return l->data;
> -- 

      parent reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30 22:49 Yu Liu
2020-07-01  0:30 ` Luiz Augusto von Dentz
2020-07-03 10:15 ` Pali Rohár [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200703101543.nrkpczji7zasqueg@pali \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Bluetooth Archive on

Archives are clonable:
	git clone --mirror linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ \
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone