From: Niels Avonds <niels.avonds@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Niels Avonds <niels@nobi.life>
Subject: [PATCH BlueZ] device: Don't mark services resolved on error
Date: Wed, 29 Jul 2020 09:16:02 +0200 [thread overview]
Message-ID: <20200729071602.12868-1-niels@nobi.life> (raw)
This fixes a bug where the service UUIDs were not rediscovered after a
failed bonding attempt because the svc_resolved flag remained set even
though the uuids list was empty.
---
src/device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/device.c b/src/device.c
index bb8e07e8f..e20c2d240 100644
--- a/src/device.c
+++ b/src/device.c
@@ -2591,7 +2591,8 @@ static void device_svc_resolved(struct btd_device *dev, uint8_t browse_type,
DBG("%s err %d", dev->path, err);
- state->svc_resolved = true;
+ if (err == 0)
+ state->svc_resolved = true;
/* Disconnection notification can happen before this function
* gets called, so don't set svc_refreshed for a disconnected
--
2.18.0
reply other threads:[~2020-07-29 7:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729071602.12868-1-niels@nobi.life \
--to=niels.avonds@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=niels@nobi.life \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).