From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFFE8C4363C for ; Sun, 4 Oct 2020 13:18:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74AAC20735 for ; Sun, 4 Oct 2020 13:18:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601817484; bh=AiiuHjZO0icMiYjb4/nKkMOXT/QNMEYb0nKe94BHd8Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=IOX797Tm0iPm6yYOa1NVpXq/vDz+BgUOMfmDhXX3p2zPa6FTdz1XrS1qU7aNkUyFp WxnB94ymC9fKOc3i9RDx1gUEJ7T3F8aOUA88FFP9zSWDiYcsPuhsVxe4mpS4Omsghq zAXhJOaV/rAzZeBcc9Rcod+GQCf/uybXT7DWnonU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726077AbgJDNSA (ORCPT ); Sun, 4 Oct 2020 09:18:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:38754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725977AbgJDNSA (ORCPT ); Sun, 4 Oct 2020 09:18:00 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5DA3B20735; Sun, 4 Oct 2020 13:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601817477; bh=AiiuHjZO0icMiYjb4/nKkMOXT/QNMEYb0nKe94BHd8Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bcfsMVPWQkqi9e5ohzJimSHJFGSt2LRqiNyD+UAVK8e2UkZh0q6AuFT/spfq1tmS4 /Nr8JRmMUbe7NxFlMcf8q04MaTDzZO6DFdHizHSkLrj5uNXGJ2zQDIx8vznDNQM6Ho OP2/F964ovcrnQ5j8ZnxcUk88cqw/ugEXaNtZKs8= Date: Sun, 4 Oct 2020 15:18:44 +0200 From: Greg Kroah-Hartman To: Bastien Nocera Cc: Marcel Holtmann , Johan Hedberg , Sathish Narsimman , "David S. Miller" , Jakub Kicinski , linux-bluetooth , "open list:NETWORKING [GENERAL]" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist" Message-ID: <20201004131844.GA185109@kroah.com> References: <20201003135449.GA2691@kroah.com> <20201003160713.GA1512229@kroah.com> <20201004105124.GA2429@kroah.com> <04e0af8618f95a4483f5a72ba90d4f8b1d9094bd.camel@hadess.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <04e0af8618f95a4483f5a72ba90d4f8b1d9094bd.camel@hadess.net> Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Sun, Oct 04, 2020 at 02:17:06PM +0200, Bastien Nocera wrote: > On Sun, 2020-10-04 at 12:51 +0200, Greg Kroah-Hartman wrote: > > On Sat, Oct 03, 2020 at 08:33:18PM +0200, Marcel Holtmann wrote: > > > Hi Greg, > > > > > > > > > This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 > > > > > > as it > > > > > > breaks all bluetooth connections on my machine. > > > > > > > > > > > > Cc: Marcel Holtmann > > > > > > Cc: Sathish Narsimman > > > > > > Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when > > > > > > updating whitelist") > > > > > > Signed-off-by: Greg Kroah-Hartman > > > > > > > > > > > > --- > > > > > > net/bluetooth/hci_request.c | 41 ++-------------------------- > > > > > > --------- > > > > > > 1 file changed, 2 insertions(+), 39 deletions(-) > > > > > > > > > > > > This has been bugging me for since 5.9-rc1, when all > > > > > > bluetooth devices > > > > > > stopped working on my desktop system.  I finally got the time > > > > > > to do > > > > > > bisection today, and it came down to this patch.  Reverting > > > > > > it on top of > > > > > > 5.9-rc7 restored bluetooth devices and now my input devices > > > > > > properly > > > > > > work. > > > > > > > > > > > > As it's almost 5.9-final, any chance this can be merged now > > > > > > to fix the > > > > > > issue? > > > > > > > > > > can you be specific what breaks since our guys and I also think > > > > > the > > > > > ChromeOS guys have been testing these series of patches > > > > > heavily. > > > > > > > > My bluetooth trackball does not connect at all.  With this > > > > reverted, it > > > > all "just works". > > > > > > > > Same I think for a Bluetooth headset, can check that again if you > > > > really > > > > need me to, but the trackball is reliable here. > > > > > > > > > When you run btmon does it indicate any errors? > > > > > > > > How do I run it and where are the errors displayed? > > > > > > you can do btmon -w trace.log and just let it run like tcdpump. > > > > Ok, attached. > > > > The device is not connecting, and then I open the gnome bluetooth > > dialog > > and it scans for devices in the area, but does not connect to my > > existing devices at all. > > > > Any ideas? > > Use bluetoothctl instead, the Bluetooth Settings from GNOME also run a > discovery the whole time the panel is opened, and this breaks a fair > number of poor quality adapters. This is worked-around in the most > recent version, but using bluetoothctl is a better debugging option in > all cases. Ok, but how do I use that tool? How do I shut down the gnome bluetooth stuff? I need newbie steps here please for what to run and what to show you. thanks, greg k-h