* [PATCH BlueZ v2] tools: fix forgotten index->mgmt_index renaming in btmgmt.c
@ 2020-10-06 15:19 Henrik Grimler
2020-10-06 15:35 ` [BlueZ,v2] " bluez.test.bot
0 siblings, 1 reply; 2+ messages in thread
From: Henrik Grimler @ 2020-10-06 15:19 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Henrik Grimler
Commit 6523d168a7c1 ("tools/btmgmt: Port to use bt_shell") seem to
have missed this. When trying to compile bluez I get:
```
tools/btmgmt.c:1229:34: warning: implicitly declaring library function 'index' \
with type 'char *(const char *, int)' [-Wimplicit-function-declaration]
config_info_rsp, UINT_TO_PTR(index), NULL)) {
^
tools/btmgmt.c:1229:34: note: include the header <strings.h> or explicitly \
provide a declaration for 'index'
[...]
aarch64-linux-android-ld: tools/btmgmt.o: in function `cmd_config':
btmgmt.c:(.text+0x544): undefined reference to `index'
aarch64-linux-android-ld: btmgmt.c:(.text+0x548): undefined reference to `index'
```
Probably only happens on system (like android) where the obsolete
index function does not exist.
---
Changes in v2:
- Update commit message to make lint bot happy
tools/btmgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/btmgmt.c b/tools/btmgmt.c
index b0b837d34..228f94efa 100644
--- a/tools/btmgmt.c
+++ b/tools/btmgmt.c
@@ -1213,7 +1213,7 @@ static void cmd_config(int argc, char **argv)
}
if (!mgmt_send(mgmt, MGMT_OP_READ_CONFIG_INFO, mgmt_index, 0, NULL,
- config_info_rsp, UINT_TO_PTR(index), NULL)) {
+ config_info_rsp, UINT_TO_PTR(mgmt_index), NULL)) {
error("Unable to send read_config_info cmd");
return bt_shell_noninteractive_quit(EXIT_FAILURE);
}
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [BlueZ,v2] tools: fix forgotten index->mgmt_index renaming in btmgmt.c
2020-10-06 15:19 [PATCH BlueZ v2] tools: fix forgotten index->mgmt_index renaming in btmgmt.c Henrik Grimler
@ 2020-10-06 15:35 ` bluez.test.bot
0 siblings, 0 replies; 2+ messages in thread
From: bluez.test.bot @ 2020-10-06 15:35 UTC (permalink / raw)
To: linux-bluetooth, henrik
[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=360347
---Test result---
##############################
Test: CheckPatch - FAIL
Output:
tools: fix forgotten index->mgmt_index renaming in btmgmt.c
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12:
config_info_rsp, UINT_TO_PTR(index), NULL)) {
WARNING:LONG_LINE: line over 80 characters
#34: FILE: tools/btmgmt.c:1216:
+ config_info_rsp, UINT_TO_PTR(mgmt_index), NULL)) {
- total: 0 errors, 2 warnings, 8 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Your patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: CheckGitLint - PASS
##############################
Test: CheckBuild - PASS
##############################
Test: MakeCheck - PASS
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-06 15:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-06 15:19 [PATCH BlueZ v2] tools: fix forgotten index->mgmt_index renaming in btmgmt.c Henrik Grimler
2020-10-06 15:35 ` [BlueZ,v2] " bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).