Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH BlueZ v3] tools: fix forgotten index->mgmt_index renaming in btmgmt.c
@ 2020-10-06 15:50 Henrik Grimler
  2020-10-06 16:38 ` [BlueZ,v3] " bluez.test.bot
  0 siblings, 1 reply; 3+ messages in thread
From: Henrik Grimler @ 2020-10-06 15:50 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Henrik Grimler

Commit 6523d168a7c1 ("tools/btmgmt: Port to use bt_shell") seem to
have missed this.  When trying to compile bluez I get:

```
tools/btmgmt.c:1229:34: warning: implicitly declaring library function 'index' \
with type 'char *(const char *, int)' [-Wimplicit-function-declaration]
                                config_info_rsp, UINT_TO_PTR(index), NULL)) {
                                                             ^
tools/btmgmt.c:1229:34: note: include the header <strings.h> or explicitly \
provide a declaration for 'index'
[...]
aarch64-linux-android-ld: tools/btmgmt.o: in function `cmd_config':
btmgmt.c:(.text+0x544): undefined reference to `index'
aarch64-linux-android-ld: btmgmt.c:(.text+0x548): undefined reference to `index'
```

Probably only happens on system (like android) where the obsolete
index function does not exist.

---
Changes in v3:
- Ensure lines in code are < 80 characters as well

Changes in v2:
- Update commit message to make lint bot happy

 tools/btmgmt.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/btmgmt.c b/tools/btmgmt.c
index b0b837d34..9daa58c54 100644
--- a/tools/btmgmt.c
+++ b/tools/btmgmt.c
@@ -1212,8 +1212,9 @@ static void cmd_config(int argc, char **argv)
 		return;
 	}
 
-	if (!mgmt_send(mgmt, MGMT_OP_READ_CONFIG_INFO, mgmt_index, 0, NULL,
-				config_info_rsp, UINT_TO_PTR(index), NULL)) {
+	if (!mgmt_send(mgmt, MGMT_OP_READ_CONFIG_INFO, mgmt_index,
+				0, NULL, config_info_rsp,
+				UINT_TO_PTR(mgmt_index), NULL)) {
 		error("Unable to send read_config_info cmd");
 		return bt_shell_noninteractive_quit(EXIT_FAILURE);
 	}
-- 
2.28.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [BlueZ,v3] tools: fix forgotten index->mgmt_index renaming in btmgmt.c
  2020-10-06 15:50 [PATCH BlueZ v3] tools: fix forgotten index->mgmt_index renaming in btmgmt.c Henrik Grimler
@ 2020-10-06 16:38 ` bluez.test.bot
  2020-10-10  7:48   ` Henrik Grimler
  0 siblings, 1 reply; 3+ messages in thread
From: bluez.test.bot @ 2020-10-06 16:38 UTC (permalink / raw)
  To: linux-bluetooth, henrik


[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=360353

---Test result---

##############################
Test: CheckPatch - FAIL
Output:
tools: fix forgotten index->mgmt_index renaming in btmgmt.c
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12: 
                                config_info_rsp, UINT_TO_PTR(index), NULL)) {

- total: 0 errors, 1 warnings, 11 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BlueZ,v3] tools: fix forgotten index->mgmt_index renaming in btmgmt.c
  2020-10-06 16:38 ` [BlueZ,v3] " bluez.test.bot
@ 2020-10-10  7:48   ` Henrik Grimler
  0 siblings, 0 replies; 3+ messages in thread
From: Henrik Grimler @ 2020-10-10  7:48 UTC (permalink / raw)
  To: linux-bluetooth

Hi, 

The lint check seem to fail due to long lines in the old code. In the
new code the same lines are shorter than 75 chars. 

Is there anything I can do to make the check pass? 

Best regards,
Henrik Grimler

On Tue, 2020-10-06 at 09:38 -0700, bluez.test.bot@gmail.com wrote:
> This is automated email and please do not reply to this email!
> 
> Dear submitter,
> 
> Thank you for submitting the patches to the linux bluetooth mailing
> list.
> This is a CI test results with your patch series:
> PW
> Link:https://patchwork.kernel.org/project/bluetooth/list/?series=360353
> 
> ---Test result---
> 
> ##############################
> Test: CheckPatch - FAIL
> Output:
> tools: fix forgotten index->mgmt_index renaming in btmgmt.c
> WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description
> (prefer a maximum 75 chars per line)
> #12: 
>                                 config_info_rsp, UINT_TO_PTR(index),
> NULL)) {
> 
> - total: 0 errors, 1 warnings, 11 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-
> inplace.
> 
> Your patch has style problems, please review.
> 
> NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO
> CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED
> SPLIT_STRING SSCANF_TO_KSTRTO
> 
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> 
> 
> ##############################
> Test: CheckGitLint - PASS
> 
> ##############################
> Test: CheckBuild - PASS
> 
> ##############################
> Test: MakeCheck - PASS
> 
> 
> 
> ---
> Regards,
> Linux Bluetooth
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-06 15:50 [PATCH BlueZ v3] tools: fix forgotten index->mgmt_index renaming in btmgmt.c Henrik Grimler
2020-10-06 16:38 ` [BlueZ,v3] " bluez.test.bot
2020-10-10  7:48   ` Henrik Grimler

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git