From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 1/3] avdtp: Fix setting disconnect timer when there is no local endpoints
Date: Tue, 16 Feb 2021 15:33:35 -0800 [thread overview]
Message-ID: <20210216233337.859955-1-luiz.dentz@gmail.com> (raw)
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
If there are not local endpoints left there is no point in starting
the disconnect timer as without any endpoint it is not possible to
configure streams anymore so the code should proceed to disconnect
immediately.
---
profiles/audio/avdtp.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
index fa72ef66a..9ddcd6464 100644
--- a/profiles/audio/avdtp.c
+++ b/profiles/audio/avdtp.c
@@ -1226,7 +1226,13 @@ void avdtp_unref(struct avdtp *session)
switch (session->state) {
case AVDTP_SESSION_STATE_CONNECTED:
- set_disconnect_timer(session);
+ /* Only set disconnect timer if there are local endpoints
+ * otherwise disconnect immediately.
+ */
+ if (queue_isempty(session->lseps))
+ connection_lost(session, ECONNRESET);
+ else
+ set_disconnect_timer(session);
break;
case AVDTP_SESSION_STATE_CONNECTING:
connection_lost(session, ECONNABORTED);
--
2.29.2
next reply other threads:[~2021-02-16 23:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 23:33 Luiz Augusto von Dentz [this message]
2021-02-16 23:33 ` [PATCH BlueZ 2/3] btio: Use G_PRIORITY_HIGH for watches Luiz Augusto von Dentz
2021-02-16 23:33 ` [PATCH BlueZ 3/3] avdtp: Remove use of G_PRIORITY_LOW Luiz Augusto von Dentz
2021-02-17 20:24 ` Miao-chen Chou
2021-02-17 21:21 ` Luiz Augusto von Dentz
2021-02-17 21:41 ` Miao-chen Chou
2021-02-16 23:57 ` [BlueZ,1/3] avdtp: Fix setting disconnect timer when there is no local endpoints bluez.test.bot
2021-02-17 19:45 ` Luiz Augusto von Dentz
2021-02-17 20:37 ` Miao-chen Chou
2021-02-17 21:24 ` Luiz Augusto von Dentz
2021-02-18 1:28 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216233337.859955-1-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).