From: Dylan Van Assche <me@dylanvanassche.be> To: linux-bluetooth@vger.kernel.org Cc: Hannu Mallat <hmallat@gmail.com>, Dylan Van Assche <me@dylanvanassche.be> Subject: [PATCH 4/4] obexd: phonebook: Workaround for PTS client not sending mandatory apparams Date: Sat, 17 Jul 2021 14:55:08 +0200 [thread overview] Message-ID: <20210717125508.29186-4-me@dylanvanassche.be> (raw) In-Reply-To: <20210717125508.29186-1-me@dylanvanassche.be> From: Hannu Mallat <hmallat@gmail.com> Some PTS clients do not send all the mandatory apparams when retrieving the phonebook. Clients such as car multimedia systems cannot be fixed, therefore working around this issue by inserting default apparams which makes these clients work as well. Cherry-picked from https://github.com/sailfishos/bluez5/commit/e8001df26e1964ddb98d02ad27ab8f909ffe2f17 Co-authored-by: Dylan Van Assche <me@dylanvanassche.be> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be> --- obexd/plugins/pbap.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/obexd/plugins/pbap.c b/obexd/plugins/pbap.c index efae92cd8..ab5236316 100644 --- a/obexd/plugins/pbap.c +++ b/obexd/plugins/pbap.c @@ -511,6 +511,21 @@ static int pbap_get(struct obex_session *os, void *user_data) rsize = 0; } + /* Workaround for PTS client not sending mandatory apparams */ + if (!rsize && g_ascii_strcasecmp(type, VCARDLISTING_TYPE) == 0) { + static const uint8_t default_apparams[] = { + 0x04, 0x02, 0xff, 0xff + }; + buffer = default_apparams; + rsize = sizeof(default_apparams); + } else if (!rsize && g_ascii_strcasecmp(type, VCARDENTRY_TYPE) == 0) { + static const uint8_t default_apparams[] = { + 0x07, 0x01, 0x00 + }; + buffer = default_apparams; + rsize = sizeof(default_apparams); + } + params = parse_aparam(buffer, rsize); if (params == NULL) return -EBADR; -- 2.32.0
next prev parent reply other threads:[~2021-07-17 12:55 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-17 12:55 [PATCH 1/4] obexd: phonebook-ebook: modernize Dylan Van Assche 2021-07-17 12:55 ` [PATCH 2/4] configure.ac: specify phonebook plugin at build time Dylan Van Assche 2021-07-17 12:55 ` [PATCH 3/4] configure.ac: add libebook dependency Dylan Van Assche 2021-07-17 12:55 ` Dylan Van Assche [this message] 2021-07-17 13:15 ` [1/4] obexd: phonebook-ebook: modernize bluez.test.bot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210717125508.29186-4-me@dylanvanassche.be \ --to=me@dylanvanassche.be \ --cc=hmallat@gmail.com \ --cc=linux-bluetooth@vger.kernel.org \ --subject='Re: [PATCH 4/4] obexd: phonebook: Workaround for PTS client not sending mandatory apparams' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).