linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bluetooth: btrsi: use non-kernel-doc comment for copyright
@ 2021-07-21  2:03 Randy Dunlap
  2021-07-21  3:17 ` bluez.test.bot
  2021-07-22 14:36 ` [PATCH] " Marcel Holtmann
  0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-07-21  2:03 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, kernel test robot, Aditya Srivastava,
	Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
	linux-bluetooth, David S. Miller, Jakub Kicinski, netdev,
	Prameela Rani Garnepudi, Sanjay Kumar Konduri, Siva Rebbagondla,
	Kalle Valo

kernel-doc complains about a non-kernel-doc comment that uses "/**"
to begin the comment, so change it to just "/*".

drivers/bluetooth/btrsi.c:2: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Copyright (c) 2017 Redpine Signals Inc.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Aditya Srivastava <yashsri421@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Cc: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Cc: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
Cc: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
---
 drivers/bluetooth/btrsi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20210720.orig/drivers/bluetooth/btrsi.c
+++ linux-next-20210720/drivers/bluetooth/btrsi.c
@@ -1,4 +1,4 @@
-/**
+/*
  * Copyright (c) 2017 Redpine Signals Inc.
  *
  * Permission to use, copy, modify, and/or distribute this software for any

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: bluetooth: btrsi: use non-kernel-doc comment for copyright
  2021-07-21  2:03 [PATCH] bluetooth: btrsi: use non-kernel-doc comment for copyright Randy Dunlap
@ 2021-07-21  3:17 ` bluez.test.bot
  2021-07-22 14:36 ` [PATCH] " Marcel Holtmann
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2021-07-21  3:17 UTC (permalink / raw)
  To: linux-bluetooth, rdunlap

[-- Attachment #1: Type: text/plain, Size: 3566 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=518651

---Test result---

Test Summary:
CheckPatch                    FAIL      0.57 seconds
GitLint                       FAIL      0.12 seconds
BuildKernel                   PASS      667.52 seconds
TestRunner: Setup             PASS      430.71 seconds
TestRunner: l2cap-tester      PASS      3.14 seconds
TestRunner: bnep-tester       PASS      2.26 seconds
TestRunner: mgmt-tester       PASS      34.45 seconds
TestRunner: rfcomm-tester     PASS      2.45 seconds
TestRunner: sco-tester        PASS      2.42 seconds
TestRunner: smp-tester        FAIL      2.49 seconds
TestRunner: userchan-tester   PASS      2.22 seconds

Details
##############################
Test: CheckPatch - FAIL - 0.57 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
bluetooth: btrsi: use non-kernel-doc comment for copyright
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#33: FILE: drivers/bluetooth/btrsi.c:1:
+/*

total: 0 errors, 1 warnings, 5 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] bluetooth: btrsi: use non-kernel-doc comment for copyright" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL - 0.12 seconds
Run gitlint with rule in .gitlint
bluetooth: btrsi: use non-kernel-doc comment for copyright
6: B1 Line exceeds max length (146>80): "drivers/bluetooth/btrsi.c:2: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst"


##############################
Test: BuildKernel - PASS - 667.52 seconds
Build Kernel with minimal configuration supports Bluetooth


##############################
Test: TestRunner: Setup - PASS - 430.71 seconds
Setup environment for running Test Runner


##############################
Test: TestRunner: l2cap-tester - PASS - 3.14 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: bnep-tester - PASS - 2.26 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: mgmt-tester - PASS - 34.45 seconds
Run test-runner with mgmt-tester
Total: 448, Passed: 445 (99.3%), Failed: 0, Not Run: 3

##############################
Test: TestRunner: rfcomm-tester - PASS - 2.45 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: sco-tester - PASS - 2.42 seconds
Run test-runner with sco-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: smp-tester - FAIL - 2.49 seconds
Run test-runner with smp-tester
Total: 8, Passed: 7 (87.5%), Failed: 1, Not Run: 0

Failed Test Cases
SMP Client - SC Request 2                            Failed       0.028 seconds

##############################
Test: TestRunner: userchan-tester - PASS - 2.22 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0



---
Regards,
Linux Bluetooth


[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 44349 bytes --]

[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3556 bytes --]

[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 616825 bytes --]

[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 11676 bytes --]

[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 9912 bytes --]

[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11705 bytes --]

[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 5453 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] bluetooth: btrsi: use non-kernel-doc comment for copyright
  2021-07-21  2:03 [PATCH] bluetooth: btrsi: use non-kernel-doc comment for copyright Randy Dunlap
  2021-07-21  3:17 ` bluez.test.bot
@ 2021-07-22 14:36 ` Marcel Holtmann
  1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2021-07-22 14:36 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: open list, kernel test robot, Aditya Srivastava, Johan Hedberg,
	Luiz Augusto von Dentz, linux-bluetooth, David S. Miller,
	Jakub Kicinski, open list:NETWORKING [GENERAL],
	Prameela Rani Garnepudi, Sanjay Kumar Konduri, Siva Rebbagondla,
	Kalle Valo

Hi Randy,

> kernel-doc complains about a non-kernel-doc comment that uses "/**"
> to begin the comment, so change it to just "/*".
> 
> drivers/bluetooth/btrsi.c:2: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>    * Copyright (c) 2017 Redpine Signals Inc.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Aditya Srivastava <yashsri421@gmail.com>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: Johan Hedberg <johan.hedberg@gmail.com>
> Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> Cc: linux-bluetooth@vger.kernel.org
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: netdev@vger.kernel.org
> Cc: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
> Cc: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
> Cc: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> ---
> drivers/bluetooth/btrsi.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-22 14:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21  2:03 [PATCH] bluetooth: btrsi: use non-kernel-doc comment for copyright Randy Dunlap
2021-07-21  3:17 ` bluez.test.bot
2021-07-22 14:36 ` [PATCH] " Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).