From: Tedd Ho-Jeong An <hj.tedd.an@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Tedd Ho-Jeong An <tedd.an@intel.com>
Subject: [RFC PATCH v3 0/9] Bluetooth: btintel: Refactoring setup routines
Date: Sat, 24 Jul 2021 00:29:56 -0700 [thread overview]
Message-ID: <20210724073005.714003-1-hj.tedd.an@gmail.com> (raw)
From: Tedd Ho-Jeong An <tedd.an@intel.com>
This patch set refactors the multiple setup routines for various Intel devices
to a combined single entry. Here are the highlight of the changes:
1. Updated hci_alloc_dev() to allocate the hdev object with an extra buffer
for the private data. btintel introduces the btintel_data struct and
store it to the private data in hdev object.
2. Added a single entry for setup and shutdown and uses the
HCI_Intel_Read_Version command to identify the device, instead of
relying on the USB VID and PID.
Also, it uses the new format of HCI_Intel_Read_Version command for
legacy ROM and legacy bootloader devices. Luckly legacy devices
support the new format.
3. Keep the state of bootloader in btintel object. The bootloader state
is agnostic to the transport type, so btintel uses the btintel_data
to keep track of the state in the private data section in hdev.
4. After identifying the setup type for the device, it uses the
correspond setup routines based on the setup type, and the setup
routines were moved from btusb to btintel.
However, actual work for the setup routines were not changed or very
minimal.
5. Since many functions were moved from btusb to btintel, clean up the
exported functions and make them static if possible.
Tedd Ho-Jeong An (9):
Bluetooth: Add support hdev to allocate private data
Bluetooth: btintel: Add combined setup and shutdown functions
Bluetooth: btintel: Refactoring setup routine for legacy ROM sku
Bluetooth: btintel: Add btintel data struct
Bluetooth: btintel: Fix the first HCI command not work with ROM
device.
Bluetooth: btintel: Add combined set_diag functions
Bluetooth: btintel: Refactoring setup routine for legacy bootloader
Bluetooth: btintel: Refactoring setup routine for TLV based booloader
Bluetooth: btintel: Clean the exported function to static
drivers/bluetooth/bfusb.c | 2 +-
drivers/bluetooth/bluecard_cs.c | 2 +-
drivers/bluetooth/bpa10x.c | 2 +-
drivers/bluetooth/bt3c_cs.c | 2 +-
drivers/bluetooth/btintel.c | 1184 ++++++++++++++++++++++++++++--
drivers/bluetooth/btintel.h | 82 +--
drivers/bluetooth/btmrvl_main.c | 2 +-
drivers/bluetooth/btmtksdio.c | 2 +-
drivers/bluetooth/btmtkuart.c | 2 +-
drivers/bluetooth/btqcomsmd.c | 2 +-
drivers/bluetooth/btrsi.c | 2 +-
drivers/bluetooth/btsdio.c | 2 +-
drivers/bluetooth/btusb.c | 1098 ++-------------------------
drivers/bluetooth/dtl1_cs.c | 2 +-
drivers/bluetooth/hci_ldisc.c | 2 +-
drivers/bluetooth/hci_serdev.c | 2 +-
drivers/bluetooth/hci_vhci.c | 2 +-
drivers/bluetooth/virtio_bt.c | 2 +-
include/net/bluetooth/hci_core.h | 7 +-
net/bluetooth/hci_core.c | 11 +-
20 files changed, 1225 insertions(+), 1187 deletions(-)
--
2.26.3
next reply other threads:[~2021-07-24 7:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 7:29 Tedd Ho-Jeong An [this message]
2021-07-24 7:29 ` [RFC PATCH v3 1/9] Bluetooth: Add support hdev to allocate private data Tedd Ho-Jeong An
2021-07-24 7:29 ` [RFC PATCH v3 2/9] Bluetooth: btintel: Add combined setup and shutdown functions Tedd Ho-Jeong An
2021-07-24 7:36 ` K, Kiran
2021-07-24 7:29 ` [RFC PATCH v3 3/9] Bluetooth: btintel: Refactoring setup routine for legacy ROM sku Tedd Ho-Jeong An
2021-07-24 7:30 ` [RFC PATCH v3 4/9] Bluetooth: btintel: Add btintel data struct Tedd Ho-Jeong An
2021-07-24 7:30 ` [RFC PATCH v3 5/9] Bluetooth: btintel: Fix the first HCI command not work with ROM device Tedd Ho-Jeong An
2021-07-24 7:30 ` [RFC PATCH v3 6/9] Bluetooth: btintel: Add combined set_diag functions Tedd Ho-Jeong An
2021-07-24 7:30 ` [RFC PATCH v3 7/9] Bluetooth: btintel: Refactoring setup routine for legacy bootloader Tedd Ho-Jeong An
2021-07-24 7:30 ` [RFC PATCH v3 8/9] Bluetooth: btintel: Refactoring setup routine for TLV based booloader Tedd Ho-Jeong An
2021-07-24 7:30 ` [RFC PATCH v3 9/9] Bluetooth: btintel: Clean the exported function to static Tedd Ho-Jeong An
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210724073005.714003-1-hj.tedd.an@gmail.com \
--to=hj.tedd.an@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=tedd.an@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).