* [PATCH] Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers
@ 2021-07-29 16:43 Michael Sun
2021-07-29 17:30 ` bluez.test.bot
2021-07-29 19:47 ` [PATCH] " Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Michael Sun @ 2021-07-29 16:43 UTC (permalink / raw)
To: linux-bluetooth
Cc: chromeos-bluetooth-upstreaming, Chethan T N, Michael Sun,
Johan Hedberg, Luiz Augusto von Dentz, Marcel Holtmann,
linux-kernel
From: Chethan T N <chethan.tumkur.narayan@intel.com>
The Intel TyphoonPeak, GarfieldPeak Bluetooth controllers
support the Microsoft vendor extension and they are using
0xFC1E for VsMsftOpCode.
Verified on a GarfieldPeak device through bluetoothctl show
Signed-off-by: Chethan T N <chethan.tumkur.narayan@intel.com>
Signed-off-by: Michael Sun <michaelfsun@google.com>
---
drivers/bluetooth/btusb.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 1876a960b3dc..23cf6e98173b 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -3031,6 +3031,17 @@ static int btusb_setup_intel_newgen(struct hci_dev *hdev)
btintel_version_info_tlv(hdev, &version);
finish:
+ /* All Intel new genration controllers support the Microsoft vendor
+ * extension are using 0xFC1E for VsMsftOpCode.
+ */
+ switch (INTEL_HW_VARIANT(version.cnvi_bt)) {
+ case 0x17:
+ case 0x18:
+ case 0x19:
+ hci_set_msft_opcode(hdev, 0xFC1E);
+ break;
+ }
+
/* Set the event mask for Intel specific vendor events. This enables
* a few extra events that are useful during general operation. It
* does not enable any debugging related events.
--
2.32.0.432.gabb21c7263-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers
2021-07-29 16:43 [PATCH] Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers Michael Sun
@ 2021-07-29 17:30 ` bluez.test.bot
2021-07-29 19:47 ` [PATCH] " Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2021-07-29 17:30 UTC (permalink / raw)
To: linux-bluetooth, michaelfsun
[-- Attachment #1: Type: text/plain, Size: 2925 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=523533
---Test result---
Test Summary:
CheckPatch PASS 0.67 seconds
GitLint FAIL 0.10 seconds
BuildKernel PASS 516.58 seconds
TestRunner: Setup PASS 339.96 seconds
TestRunner: l2cap-tester PASS 2.52 seconds
TestRunner: bnep-tester PASS 1.92 seconds
TestRunner: mgmt-tester PASS 30.68 seconds
TestRunner: rfcomm-tester PASS 2.12 seconds
TestRunner: sco-tester PASS 2.05 seconds
TestRunner: smp-tester FAIL 2.11 seconds
TestRunner: userchan-tester PASS 1.95 seconds
Details
##############################
Test: CheckPatch - PASS - 0.67 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
##############################
Test: GitLint - FAIL - 0.10 seconds
Run gitlint with rule in .gitlint
Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers
1: T1 Title exceeds max length (77>72): "Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers"
##############################
Test: BuildKernel - PASS - 516.58 seconds
Build Kernel with minimal configuration supports Bluetooth
##############################
Test: TestRunner: Setup - PASS - 339.96 seconds
Setup environment for running Test Runner
##############################
Test: TestRunner: l2cap-tester - PASS - 2.52 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: bnep-tester - PASS - 1.92 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: mgmt-tester - PASS - 30.68 seconds
Run test-runner with mgmt-tester
Total: 448, Passed: 445 (99.3%), Failed: 0, Not Run: 3
##############################
Test: TestRunner: rfcomm-tester - PASS - 2.12 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: sco-tester - PASS - 2.05 seconds
Run test-runner with sco-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: smp-tester - FAIL - 2.11 seconds
Run test-runner with smp-tester
Total: 8, Passed: 7 (87.5%), Failed: 1, Not Run: 0
Failed Test Cases
SMP Client - SC Request 2 Failed 0.022 seconds
##############################
Test: TestRunner: userchan-tester - PASS - 1.95 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0
---
Regards,
Linux Bluetooth
[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 44386 bytes --]
[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3593 bytes --]
[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 616863 bytes --]
[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 11713 bytes --]
[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 9947 bytes --]
[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11741 bytes --]
[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 5490 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers
2021-07-29 16:43 [PATCH] Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers Michael Sun
2021-07-29 17:30 ` bluez.test.bot
@ 2021-07-29 19:47 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2021-07-29 19:47 UTC (permalink / raw)
To: Michael Sun
Cc: linux-bluetooth, CrosBT Upstreaming, Chethan T N, Johan Hedberg,
Luiz Augusto von Dentz, linux-kernel
Hi Michael,
> The Intel TyphoonPeak, GarfieldPeak Bluetooth controllers
> support the Microsoft vendor extension and they are using
> 0xFC1E for VsMsftOpCode.
>
> Verified on a GarfieldPeak device through bluetoothctl show
>
> Signed-off-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> Signed-off-by: Michael Sun <michaelfsun@google.com>
> ---
>
> drivers/bluetooth/btusb.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-29 19:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29 16:43 [PATCH] Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers Michael Sun
2021-07-29 17:30 ` bluez.test.bot
2021-07-29 19:47 ` [PATCH] " Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).