From: Archie Pusaka <apusaka@google.com>
To: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: CrosBT Upstreaming <chromeos-bluetooth-upstreaming@chromium.org>,
Archie Pusaka <apusaka@chromium.org>
Subject: [Bluez PATCH 14/62] monitor: Inclusive language in LE states
Date: Fri, 13 Aug 2021 20:17:59 +0800 [thread overview]
Message-ID: <20210813201256.Bluez.14.Iedb876c1f066370a58faad16ab17f846975ea7d9@changeid> (raw)
In-Reply-To: <20210813121848.3686029-1-apusaka@google.com>
From: Archie Pusaka <apusaka@chromium.org>
"central" and "peripheral" are preferred, as reflected in the BT
core spec 5.3.
---
monitor/packet.c | 110 +++++++++++++++++++++++------------------------
1 file changed, 55 insertions(+), 55 deletions(-)
diff --git a/monitor/packet.c b/monitor/packet.c
index b6c7fe7234..3609235d06 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -2722,11 +2722,11 @@ void packet_print_features_msft(const uint8_t *features)
#define LE_STATE_ACTIVE_SCAN 0x0020
#define LE_STATE_PASSIVE_SCAN 0x0040
#define LE_STATE_INITIATING 0x0080
-#define LE_STATE_CONN_MASTER 0x0100
-#define LE_STATE_CONN_SLAVE 0x0200
-#define LE_STATE_MASTER_MASTER 0x0400
-#define LE_STATE_SLAVE_SLAVE 0x0800
-#define LE_STATE_MASTER_SLAVE 0x1000
+#define LE_STATE_CONN_CENTRAL 0x0100
+#define LE_STATE_CONN_PERIPHERAL 0x0200
+#define LE_STATE_CENTRAL_CENTRAL 0x0400
+#define LE_STATE_PERIPHERAL_PERIPHERAL 0x0800
+#define LE_STATE_CENTRAL_PERIPHERAL 0x1000
static const struct bitfield_data le_states_desc_table[] = {
{ 0, "Scannable Advertising State" },
@@ -2749,59 +2749,59 @@ static const struct {
uint8_t bit;
uint16_t states;
} le_states_comb_table[] = {
- { 0, LE_STATE_NONCONN_ADV },
- { 1, LE_STATE_SCAN_ADV },
- { 2, LE_STATE_CONN_ADV },
- { 3, LE_STATE_HIGH_DIRECT_ADV },
- { 4, LE_STATE_PASSIVE_SCAN },
- { 5, LE_STATE_ACTIVE_SCAN },
- { 6, LE_STATE_INITIATING | LE_STATE_CONN_MASTER },
- { 7, LE_STATE_CONN_SLAVE },
- { 8, LE_STATE_PASSIVE_SCAN | LE_STATE_NONCONN_ADV },
- { 9, LE_STATE_PASSIVE_SCAN | LE_STATE_SCAN_ADV },
- { 10, LE_STATE_PASSIVE_SCAN | LE_STATE_CONN_ADV },
- { 11, LE_STATE_PASSIVE_SCAN | LE_STATE_HIGH_DIRECT_ADV },
- { 12, LE_STATE_ACTIVE_SCAN | LE_STATE_NONCONN_ADV },
- { 13, LE_STATE_ACTIVE_SCAN | LE_STATE_SCAN_ADV },
- { 14, LE_STATE_ACTIVE_SCAN | LE_STATE_CONN_ADV },
- { 15, LE_STATE_ACTIVE_SCAN | LE_STATE_HIGH_DIRECT_ADV },
- { 16, LE_STATE_INITIATING | LE_STATE_NONCONN_ADV },
- { 17, LE_STATE_INITIATING | LE_STATE_SCAN_ADV },
- { 18, LE_STATE_CONN_MASTER | LE_STATE_NONCONN_ADV },
- { 19, LE_STATE_CONN_MASTER | LE_STATE_SCAN_ADV },
- { 20, LE_STATE_CONN_SLAVE | LE_STATE_NONCONN_ADV },
- { 21, LE_STATE_CONN_SLAVE | LE_STATE_SCAN_ADV },
- { 22, LE_STATE_INITIATING | LE_STATE_PASSIVE_SCAN },
- { 23, LE_STATE_INITIATING | LE_STATE_ACTIVE_SCAN },
- { 24, LE_STATE_CONN_MASTER | LE_STATE_PASSIVE_SCAN },
- { 25, LE_STATE_CONN_MASTER | LE_STATE_ACTIVE_SCAN },
- { 26, LE_STATE_CONN_SLAVE | LE_STATE_PASSIVE_SCAN },
- { 27, LE_STATE_CONN_SLAVE | LE_STATE_ACTIVE_SCAN },
- { 28, LE_STATE_INITIATING | LE_STATE_CONN_MASTER |
- LE_STATE_MASTER_MASTER },
- { 29, LE_STATE_LOW_DIRECT_ADV },
- { 30, LE_STATE_LOW_DIRECT_ADV | LE_STATE_PASSIVE_SCAN },
- { 31, LE_STATE_LOW_DIRECT_ADV | LE_STATE_ACTIVE_SCAN },
+ { 0, LE_STATE_NONCONN_ADV },
+ { 1, LE_STATE_SCAN_ADV },
+ { 2, LE_STATE_CONN_ADV },
+ { 3, LE_STATE_HIGH_DIRECT_ADV },
+ { 4, LE_STATE_PASSIVE_SCAN },
+ { 5, LE_STATE_ACTIVE_SCAN },
+ { 6, LE_STATE_INITIATING | LE_STATE_CONN_CENTRAL },
+ { 7, LE_STATE_CONN_PERIPHERAL },
+ { 8, LE_STATE_PASSIVE_SCAN | LE_STATE_NONCONN_ADV },
+ { 9, LE_STATE_PASSIVE_SCAN | LE_STATE_SCAN_ADV },
+ { 10, LE_STATE_PASSIVE_SCAN | LE_STATE_CONN_ADV },
+ { 11, LE_STATE_PASSIVE_SCAN | LE_STATE_HIGH_DIRECT_ADV },
+ { 12, LE_STATE_ACTIVE_SCAN | LE_STATE_NONCONN_ADV },
+ { 13, LE_STATE_ACTIVE_SCAN | LE_STATE_SCAN_ADV },
+ { 14, LE_STATE_ACTIVE_SCAN | LE_STATE_CONN_ADV },
+ { 15, LE_STATE_ACTIVE_SCAN | LE_STATE_HIGH_DIRECT_ADV },
+ { 16, LE_STATE_INITIATING | LE_STATE_NONCONN_ADV },
+ { 17, LE_STATE_INITIATING | LE_STATE_SCAN_ADV },
+ { 18, LE_STATE_CONN_CENTRAL | LE_STATE_NONCONN_ADV },
+ { 19, LE_STATE_CONN_CENTRAL | LE_STATE_SCAN_ADV },
+ { 20, LE_STATE_CONN_PERIPHERAL | LE_STATE_NONCONN_ADV },
+ { 21, LE_STATE_CONN_PERIPHERAL | LE_STATE_SCAN_ADV },
+ { 22, LE_STATE_INITIATING | LE_STATE_PASSIVE_SCAN },
+ { 23, LE_STATE_INITIATING | LE_STATE_ACTIVE_SCAN },
+ { 24, LE_STATE_CONN_CENTRAL | LE_STATE_PASSIVE_SCAN },
+ { 25, LE_STATE_CONN_CENTRAL | LE_STATE_ACTIVE_SCAN },
+ { 26, LE_STATE_CONN_PERIPHERAL | LE_STATE_PASSIVE_SCAN },
+ { 27, LE_STATE_CONN_PERIPHERAL | LE_STATE_ACTIVE_SCAN },
+ { 28, LE_STATE_INITIATING | LE_STATE_CONN_CENTRAL |
+ LE_STATE_CENTRAL_CENTRAL },
+ { 29, LE_STATE_LOW_DIRECT_ADV },
+ { 30, LE_STATE_LOW_DIRECT_ADV | LE_STATE_PASSIVE_SCAN },
+ { 31, LE_STATE_LOW_DIRECT_ADV | LE_STATE_ACTIVE_SCAN },
{ 32, LE_STATE_INITIATING | LE_STATE_CONN_ADV |
- LE_STATE_MASTER_SLAVE },
+ LE_STATE_CENTRAL_PERIPHERAL },
{ 33, LE_STATE_INITIATING | LE_STATE_HIGH_DIRECT_ADV |
- LE_STATE_MASTER_SLAVE },
+ LE_STATE_CENTRAL_PERIPHERAL },
{ 34, LE_STATE_INITIATING | LE_STATE_LOW_DIRECT_ADV |
- LE_STATE_MASTER_SLAVE },
- { 35, LE_STATE_CONN_MASTER | LE_STATE_CONN_ADV |
- LE_STATE_MASTER_SLAVE },
- { 36, LE_STATE_CONN_MASTER | LE_STATE_HIGH_DIRECT_ADV |
- LE_STATE_MASTER_SLAVE },
- { 37, LE_STATE_CONN_MASTER | LE_STATE_LOW_DIRECT_ADV |
- LE_STATE_MASTER_SLAVE },
- { 38, LE_STATE_CONN_SLAVE | LE_STATE_CONN_ADV |
- LE_STATE_MASTER_SLAVE },
- { 39, LE_STATE_CONN_SLAVE | LE_STATE_HIGH_DIRECT_ADV |
- LE_STATE_SLAVE_SLAVE },
- { 40, LE_STATE_CONN_SLAVE | LE_STATE_LOW_DIRECT_ADV |
- LE_STATE_SLAVE_SLAVE },
- { 41, LE_STATE_INITIATING | LE_STATE_CONN_SLAVE |
- LE_STATE_MASTER_SLAVE },
+ LE_STATE_CENTRAL_PERIPHERAL },
+ { 35, LE_STATE_CONN_CENTRAL | LE_STATE_CONN_ADV |
+ LE_STATE_CENTRAL_PERIPHERAL },
+ { 36, LE_STATE_CONN_CENTRAL | LE_STATE_HIGH_DIRECT_ADV |
+ LE_STATE_CENTRAL_PERIPHERAL },
+ { 37, LE_STATE_CONN_CENTRAL | LE_STATE_LOW_DIRECT_ADV |
+ LE_STATE_CENTRAL_PERIPHERAL },
+ { 38, LE_STATE_CONN_PERIPHERAL | LE_STATE_CONN_ADV |
+ LE_STATE_CENTRAL_PERIPHERAL },
+ { 39, LE_STATE_CONN_PERIPHERAL | LE_STATE_HIGH_DIRECT_ADV |
+ LE_STATE_PERIPHERAL_PERIPHERAL },
+ { 40, LE_STATE_CONN_PERIPHERAL | LE_STATE_LOW_DIRECT_ADV |
+ LE_STATE_PERIPHERAL_PERIPHERAL },
+ { 41, LE_STATE_INITIATING | LE_STATE_CONN_PERIPHERAL |
+ LE_STATE_CENTRAL_PERIPHERAL },
{ }
};
--
2.33.0.rc1.237.g0d66db33f3-goog
next prev parent reply other threads:[~2021-08-13 12:20 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 12:17 [Bluez PATCH 00/62] Inclusive language changes Archie Pusaka
2021-08-13 12:17 ` [Bluez PATCH 01/62] lib: Inclusive language in HCI commands and events Archie Pusaka
2021-08-13 12:49 ` Inclusive language changes bluez.test.bot
2021-08-13 19:26 ` [Bluez PATCH 01/62] lib: Inclusive language in HCI commands and events Marcel Holtmann
2021-08-13 21:47 ` Luiz Augusto von Dentz
2021-08-16 15:59 ` Marcel Holtmann
2021-08-13 12:17 ` [Bluez PATCH 02/62] lib: Inclusive language in consts and strings Archie Pusaka
2021-08-13 12:17 ` [Bluez PATCH 03/62] tools/hciconfig: Inclusive language update Archie Pusaka
2021-08-13 12:17 ` [Bluez PATCH 04/62] core: Inclusive language for l2cap Archie Pusaka
2021-08-13 12:17 ` [Bluez PATCH 05/62] core: Inclusive language for rfcomm Archie Pusaka
2021-08-13 12:17 ` [Bluez PATCH 06/62] lib: Inclusive language for filtering devices Archie Pusaka
2021-08-13 12:17 ` [Bluez PATCH 07/62] lib/mgmt: Inclusive language for LTK Archie Pusaka
2021-08-13 12:17 ` [Bluez PATCH 08/62] doc/mgmt: Inclusive language update Archie Pusaka
2021-08-13 12:17 ` [Bluez PATCH 09/62] btio: Inclusive language changes Archie Pusaka
2021-08-13 12:17 ` [Bluez PATCH 10/62] shared/ad: " Archie Pusaka
2021-08-13 12:17 ` [Bluez PATCH 11/62] shared/hfp: " Archie Pusaka
2021-08-13 12:17 ` [Bluez PATCH 12/62] monitor: Inclusive language in struct member Archie Pusaka
2021-08-13 12:17 ` [Bluez PATCH 13/62] monitor: Inclusive language in SMP related things Archie Pusaka
2021-08-13 12:17 ` Archie Pusaka [this message]
2021-08-13 12:18 ` [Bluez PATCH 15/62] monitor: Inclusive language in LL feature Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 16/62] monitor: Inclusive language in link key transaction Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 17/62] monitor: Inclusive language in peripheral broadcast Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 18/62] monitor: Inclusive language in peripheral page response timeout Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 19/62] monitor: Inclusive language in consts and strings Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 20/62] monitor: Inclusive language in filtering devices Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 21/62] emulator: Inclusive language in naming Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 22/62] emulator: Inclusive language in strings Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 23/62] emulator: Inclusive language in filtering device Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 24/62] tools: Inclusive language in referring the central address Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 25/62] tools/parser/hci: Inclusive language changes Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 26/62] tools/parser/smp: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 27/62] tools/3dsp: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 28/62] tools/mgmt-tester: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 29/62] tools/bdaddr: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 30/62] tools/hciconfig: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 31/62] tools/meshctl: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 32/62] tools/mgmt-tester: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 33/62] tools/parser: Inclusive language in struct member Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 34/62] tools/parser/lmp: Inclusive language changes Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 35/62] tools/parser/avdtp: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 36/62] tools/parser/csr: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 37/62] tools/btpclientctl: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 38/62] tools/l2cap-tester: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 39/62] tools/hci-tester: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 40/62] tools/btiotest: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 41/62] tools/hcitool: Inclusive language changes, central peripheral Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 42/62] tools/hcitool: Inclusive language changes, accept list Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 43/62] tools/l2test: Inclusive language changes Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 44/62] tools/rctest: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 45/62] tools/rfcomm: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 46/62] plugins/sixaxis: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 47/62] profiles/audio: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 48/62] profiles/health: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 49/62] sdp: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 50/62] adapter: Inclusive language for central and peripheral Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 51/62] adapter: Inclusive language for storing LTK Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 52/62] adapter: Inclusive language for device filtering Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 53/62] client: Inclusive language changes Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 54/62] mesh: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 55/62] tools/mesh: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 56/62] tools/mesh-gatt: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 57/62] unit/mesh: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 58/62] doc/mesh: " Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 59/62] android: Inclusive language for volume control Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 60/62] android: Inclusive language for describing relation Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 61/62] android: Inclusive language for filtering devices Archie Pusaka
2021-08-13 12:18 ` [Bluez PATCH 62/62] android: Inclusive language in storing LTK Archie Pusaka
2021-08-13 21:42 ` [Bluez PATCH 00/62] Inclusive language changes Luiz Augusto von Dentz
2021-08-14 5:22 ` Archie Pusaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210813201256.Bluez.14.Iedb876c1f066370a58faad16ab17f846975ea7d9@changeid \
--to=apusaka@google.com \
--cc=apusaka@chromium.org \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).