* [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report
@ 2021-09-13 7:28 Joseph Hwang
2021-09-13 7:28 ` [PATCH v3 2/3] Bluetooth: hci_qca: Set up Qualcomm WCN399x for Android BQR commands Joseph Hwang
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Joseph Hwang @ 2021-09-13 7:28 UTC (permalink / raw)
To: linux-bluetooth, marcel, luiz.dentz, pali
Cc: josephsih, chromeos-bluetooth-upstreaming, Joseph Hwang,
kernel test robot, Miao-chen Chou, Johan Hedberg, linux-kernel
Add the btandroid.c file to support Android BQR commands.
This module may be referenced by btusb, btrtl, and hci_qca when a
Bluetooth controller supports the Android Bluetooth Quality Report.
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Signed-off-by: Joseph Hwang <josephsih@chromium.org>
---
Changes in v3:
- Fix the auto build test ERROR
"undefined symbol: btandroid_set_quality_report" that occurred
with some kernel configs.
- Note that the mgmt-tester "Read Exp Feature - Success" failed.
But on my test device, the same test passed. Please kindly let me
know what may be going wrong. These patches do not actually
modify read/set experimental features.
- As to CheckPatch failed. No need to modify the MAINTAINERS file.
Thanks.
Changes in v2:
- Fix the titles of patches 2/3 and 3/3 and reduce their lengths.
drivers/bluetooth/Kconfig | 5 ++
drivers/bluetooth/Makefile | 1 +
drivers/bluetooth/btandroid.c | 106 ++++++++++++++++++++++++++++++++++
drivers/bluetooth/btandroid.h | 10 ++++
4 files changed, 122 insertions(+)
create mode 100644 drivers/bluetooth/btandroid.c
create mode 100644 drivers/bluetooth/btandroid.h
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index 851842372c9b..0be352cdc6c9 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -19,10 +19,14 @@ config BT_QCA
tristate
select FW_LOADER
+config BT_HCIBTANDROID
+ tristate
+
config BT_HCIBTUSB
tristate "HCI USB driver"
depends on USB
select BT_INTEL
+ select BT_HCIBTANDROID
help
Bluetooth HCI USB driver.
This driver is required if you want to use Bluetooth devices with
@@ -90,6 +94,7 @@ config BT_HCIUART
depends on SERIAL_DEV_BUS || !SERIAL_DEV_BUS
depends on NVMEM || !NVMEM
depends on TTY
+ select BT_HCIBTANDROID
help
Bluetooth HCI UART driver.
This driver is required if you want to use Bluetooth devices with
diff --git a/drivers/bluetooth/Makefile b/drivers/bluetooth/Makefile
index 16286ea2655d..3a2ca2eb7cd7 100644
--- a/drivers/bluetooth/Makefile
+++ b/drivers/bluetooth/Makefile
@@ -13,6 +13,7 @@ obj-$(CONFIG_BT_HCIBT3C) += bt3c_cs.o
obj-$(CONFIG_BT_HCIBLUECARD) += bluecard_cs.o
obj-$(CONFIG_BT_HCIBTUSB) += btusb.o
+obj-$(CONFIG_BT_HCIBTANDROID) += btandroid.o
obj-$(CONFIG_BT_HCIBTSDIO) += btsdio.o
obj-$(CONFIG_BT_INTEL) += btintel.o
diff --git a/drivers/bluetooth/btandroid.c b/drivers/bluetooth/btandroid.c
new file mode 100644
index 000000000000..fffacc8d67cc
--- /dev/null
+++ b/drivers/bluetooth/btandroid.c
@@ -0,0 +1,106 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Support for Android Bluetooth Quality Report (BQR) specifications
+ * https://source.android.com/devices/bluetooth/hci_requirements
+ *
+ * Copyright (C) 2021 Google Corporation
+ */
+
+#include <linux/module.h>
+
+#include <net/bluetooth/bluetooth.h>
+#include <net/bluetooth/hci.h>
+
+#include "btandroid.h"
+
+#define VERSION "0.1"
+
+/*
+ * Reference for the command op codes and parameters below:
+ * https://source.android.com/devices/bluetooth/hci_requirements#bluetooth-quality-report-command
+ */
+#define BQR_COMMAND_OCF 0x015e
+#define BQR_OPCODE hci_opcode_pack(0x3f, BQR_COMMAND_OCF)
+
+/* report action */
+#define REPORT_ACTION_ADD 0x00
+#define REPORT_ACTION_DELETE 0x01
+#define REPORT_ACTION_CLEAR 0x02
+
+/* BQR event masks */
+#define QUALITY_MONITORING (1 << 0)
+#define APPRAOCHING_LSTO (1 << 1)
+#define A2DP_AUDIO_CHOPPY (1 << 2)
+#define SCO_VOICE_CHOPPY (1 << 3)
+
+#define DEFAULT_BQR_EVENT_MASK (QUALITY_MONITORING | APPRAOCHING_LSTO | \
+ A2DP_AUDIO_CHOPPY | SCO_VOICE_CHOPPY)
+
+/*
+ * Reporting at seconds so as not to stress the controller too much.
+ * Range: 0 ~ 65535 ms
+ */
+#define DEFALUT_REPORT_INTERVAL_MS 5000
+
+struct android_bqr_cp {
+ __u8 report_action;
+ __u32 event_mask;
+ __u16 min_report_interval;
+} __packed;
+
+static int enable_quality_report(struct hci_dev *hdev)
+{
+ struct sk_buff *skb;
+ struct android_bqr_cp cp;
+
+ cp.report_action = REPORT_ACTION_ADD;
+ cp.event_mask = DEFAULT_BQR_EVENT_MASK;
+ cp.min_report_interval = DEFALUT_REPORT_INTERVAL_MS;
+
+ skb = __hci_cmd_sync(hdev, BQR_OPCODE, sizeof(cp), &cp,
+ HCI_CMD_TIMEOUT);
+ if (IS_ERR(skb)) {
+ bt_dev_err(hdev, "Enabling Android BQR failed (%ld)",
+ PTR_ERR(skb));
+ return PTR_ERR(skb);
+ }
+
+ kfree_skb(skb);
+ return 0;
+}
+
+static int disable_quality_report(struct hci_dev *hdev)
+{
+ struct sk_buff *skb;
+ struct android_bqr_cp cp = { 0 };
+
+ cp.report_action = REPORT_ACTION_CLEAR;
+
+ skb = __hci_cmd_sync(hdev, BQR_OPCODE, sizeof(cp), &cp,
+ HCI_CMD_TIMEOUT);
+ if (IS_ERR(skb)) {
+ bt_dev_err(hdev, "Disabling Android BQR failed (%ld)",
+ PTR_ERR(skb));
+ return PTR_ERR(skb);
+ }
+
+ kfree_skb(skb);
+ return 0;
+}
+
+int btandroid_set_quality_report(struct hci_dev *hdev, bool enable)
+{
+ bt_dev_info(hdev, "quality report enable %d", enable);
+
+ /* Enable or disable the quality report feature. */
+ if (enable)
+ return enable_quality_report(hdev);
+ else
+ return disable_quality_report(hdev);
+}
+EXPORT_SYMBOL_GPL(btandroid_set_quality_report);
+
+MODULE_AUTHOR("Google");
+MODULE_DESCRIPTION("Support for Android Bluetooth Specification " VERSION);
+MODULE_VERSION(VERSION);
+MODULE_LICENSE("GPL");
diff --git a/drivers/bluetooth/btandroid.h b/drivers/bluetooth/btandroid.h
new file mode 100644
index 000000000000..6abc9e8e0838
--- /dev/null
+++ b/drivers/bluetooth/btandroid.h
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * Bluetooth support for Android specifications
+ *
+ * Copyright (C) 2021 Google Corporation
+ */
+
+#include <net/bluetooth/hci_core.h>
+
+int btandroid_set_quality_report(struct hci_dev *hdev, bool enable);
--
2.33.0.309.g3052b89438-goog
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 2/3] Bluetooth: hci_qca: Set up Qualcomm WCN399x for Android BQR commands
2021-09-13 7:28 [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report Joseph Hwang
@ 2021-09-13 7:28 ` Joseph Hwang
2021-09-13 7:28 ` [PATCH v3 3/3] Bluetooth: btrtl: Set up Realtek 8822CE " Joseph Hwang
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Joseph Hwang @ 2021-09-13 7:28 UTC (permalink / raw)
To: linux-bluetooth, marcel, luiz.dentz, pali
Cc: josephsih, chromeos-bluetooth-upstreaming, Joseph Hwang,
kernel test robot, Miao-chen Chou, Johan Hedberg, linux-kernel
This patch sets up Qualcomm WCN399x to support the Android BQR commands.
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Signed-off-by: Joseph Hwang <josephsih@chromium.org>
---
Changes in v3:
- Fix the auto build test ERROR
"undefined symbol: btandroid_set_quality_report" that occurred
with some kernel configs.
Changes in v2:
- Fix the title
drivers/bluetooth/hci_qca.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 53deea2eb7b4..bf576046681d 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -38,6 +38,7 @@
#include "hci_uart.h"
#include "btqca.h"
+#include "btandroid.h"
/* HCI_IBS protocol messages */
#define HCI_IBS_SLEEP_IND 0xFE
@@ -1730,6 +1731,7 @@ static int qca_setup(struct hci_uart *hu)
if (qca_is_wcn399x(soc_type) ||
qca_is_wcn6750(soc_type)) {
set_bit(HCI_QUIRK_USE_BDADDR_PROPERTY, &hdev->quirks);
+ hdev->set_quality_report = btandroid_set_quality_report;
ret = qca_read_soc_version(hdev, &ver, soc_type);
if (ret)
--
2.33.0.309.g3052b89438-goog
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 3/3] Bluetooth: btrtl: Set up Realtek 8822CE for Android BQR commands
2021-09-13 7:28 [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report Joseph Hwang
2021-09-13 7:28 ` [PATCH v3 2/3] Bluetooth: hci_qca: Set up Qualcomm WCN399x for Android BQR commands Joseph Hwang
@ 2021-09-13 7:28 ` Joseph Hwang
2021-09-13 7:59 ` [v3,1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report bluez.test.bot
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Joseph Hwang @ 2021-09-13 7:28 UTC (permalink / raw)
To: linux-bluetooth, marcel, luiz.dentz, pali
Cc: josephsih, chromeos-bluetooth-upstreaming, Joseph Hwang,
kernel test robot, Miao-chen Chou, Johan Hedberg, linux-kernel
This patch sets up Realtek 8822CE to support the Android BQR commands.
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Signed-off-by: Joseph Hwang <josephsih@chromium.org>
---
Changes in v3:
- Fix the auto build test ERROR
"undefined symbol: btandroid_set_quality_report" that occurred
with some kernel configs.
Changes in v2:
- Fix the title
drivers/bluetooth/btrtl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 1f8afa0244d8..e0bcdbe03eca 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -14,6 +14,7 @@
#include <net/bluetooth/hci_core.h>
#include "btrtl.h"
+#include "btandroid.h"
#define VERSION "0.1"
@@ -740,12 +741,13 @@ void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
/* Enable central-peripheral role (able to create new connections with
* an existing connection in slave role).
*/
- /* Enable WBS supported for the specific Realtek devices. */
+ /* Enable WBS and quality report supported by the specific devices. */
switch (btrtl_dev->project_id) {
case CHIP_ID_8822C:
case CHIP_ID_8852A:
set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
+ hdev->set_quality_report = btandroid_set_quality_report;
break;
default:
rtl_dev_dbg(hdev, "Central-peripheral role not enabled.");
--
2.33.0.309.g3052b89438-goog
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [v3,1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report
2021-09-13 7:28 [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report Joseph Hwang
2021-09-13 7:28 ` [PATCH v3 2/3] Bluetooth: hci_qca: Set up Qualcomm WCN399x for Android BQR commands Joseph Hwang
2021-09-13 7:28 ` [PATCH v3 3/3] Bluetooth: btrtl: Set up Realtek 8822CE " Joseph Hwang
@ 2021-09-13 7:59 ` bluez.test.bot
2021-09-13 9:55 ` [PATCH v3 1/3] " Pavel Machek
2021-09-13 14:32 ` Marcel Holtmann
4 siblings, 0 replies; 7+ messages in thread
From: bluez.test.bot @ 2021-09-13 7:59 UTC (permalink / raw)
To: linux-bluetooth, josephsih
[-- Attachment #1: Type: text/plain, Size: 3313 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=545579
---Test result---
Test Summary:
CheckPatch FAIL 0.96 seconds
GitLint PASS 0.30 seconds
BuildKernel PASS 510.67 seconds
TestRunner: Setup PASS 337.70 seconds
TestRunner: l2cap-tester PASS 2.52 seconds
TestRunner: bnep-tester PASS 1.89 seconds
TestRunner: mgmt-tester FAIL 31.24 seconds
TestRunner: rfcomm-tester PASS 2.09 seconds
TestRunner: sco-tester PASS 2.04 seconds
TestRunner: smp-tester PASS 2.07 seconds
TestRunner: userchan-tester PASS 1.89 seconds
Details
##############################
Test: CheckPatch - FAIL - 0.96 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
Bluetooth: btandroid: Support Android Bluetooth Quality Report
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#57:
new file mode 100644
total: 0 errors, 1 warnings, 144 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] Bluetooth: btandroid: Support Android Bluetooth Quality" has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - PASS - 0.30 seconds
Run gitlint with rule in .gitlint
##############################
Test: BuildKernel - PASS - 510.67 seconds
Build Kernel with minimal configuration supports Bluetooth
##############################
Test: TestRunner: Setup - PASS - 337.70 seconds
Setup environment for running Test Runner
##############################
Test: TestRunner: l2cap-tester - PASS - 2.52 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: bnep-tester - PASS - 1.89 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: mgmt-tester - FAIL - 31.24 seconds
Run test-runner with mgmt-tester
Total: 452, Passed: 451 (99.8%), Failed: 1, Not Run: 0
Failed Test Cases
Read Exp Feature - Success Failed 0.013 seconds
##############################
Test: TestRunner: rfcomm-tester - PASS - 2.09 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: sco-tester - PASS - 2.04 seconds
Run test-runner with sco-tester
Total: 11, Passed: 11 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: smp-tester - PASS - 2.07 seconds
Run test-runner with smp-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: userchan-tester - PASS - 1.89 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0
---
Regards,
Linux Bluetooth
[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 51568 bytes --]
[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3934 bytes --]
[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 626848 bytes --]
[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 14791 bytes --]
[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 13045 bytes --]
[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11859 bytes --]
[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 6515 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report
2021-09-13 7:28 [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report Joseph Hwang
` (2 preceding siblings ...)
2021-09-13 7:59 ` [v3,1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report bluez.test.bot
@ 2021-09-13 9:55 ` Pavel Machek
2021-09-13 14:32 ` Marcel Holtmann
4 siblings, 0 replies; 7+ messages in thread
From: Pavel Machek @ 2021-09-13 9:55 UTC (permalink / raw)
To: Joseph Hwang
Cc: linux-bluetooth, marcel, luiz.dentz, pali, josephsih,
chromeos-bluetooth-upstreaming, kernel test robot,
Miao-chen Chou, Johan Hedberg, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
Hi!
> +config BT_HCIBTANDROID
> + tristate
Calling it btquality (or something) would be better.
> index 000000000000..fffacc8d67cc
> --- /dev/null
> +++ b/drivers/bluetooth/btandroid.c
Same here.
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report
2021-09-13 7:28 [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report Joseph Hwang
` (3 preceding siblings ...)
2021-09-13 9:55 ` [PATCH v3 1/3] " Pavel Machek
@ 2021-09-13 14:32 ` Marcel Holtmann
2021-09-26 7:14 ` Joseph Hwang
4 siblings, 1 reply; 7+ messages in thread
From: Marcel Holtmann @ 2021-09-13 14:32 UTC (permalink / raw)
To: Joseph Hwang
Cc: linux-bluetooth, Luiz Augusto von Dentz, Pali Rohár,
Joseph Hwang, CrosBT Upstreaming, kernel test robot,
Miao-chen Chou, Johan Hedberg, linux-kernel
Hi Joseph,
> Add the btandroid.c file to support Android BQR commands.
>
> This module may be referenced by btusb, btrtl, and hci_qca when a
> Bluetooth controller supports the Android Bluetooth Quality Report.
>
> Reported-by: kernel test robot <lkp@intel.com>
>
> Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> Signed-off-by: Joseph Hwang <josephsih@chromium.org>
> ---
>
> Changes in v3:
> - Fix the auto build test ERROR
> "undefined symbol: btandroid_set_quality_report" that occurred
> with some kernel configs.
> - Note that the mgmt-tester "Read Exp Feature - Success" failed.
> But on my test device, the same test passed. Please kindly let me
> know what may be going wrong. These patches do not actually
> modify read/set experimental features.
> - As to CheckPatch failed. No need to modify the MAINTAINERS file.
> Thanks.
>
> Changes in v2:
> - Fix the titles of patches 2/3 and 3/3 and reduce their lengths.
>
> drivers/bluetooth/Kconfig | 5 ++
> drivers/bluetooth/Makefile | 1 +
> drivers/bluetooth/btandroid.c | 106 ++++++++++++++++++++++++++++++++++
> drivers/bluetooth/btandroid.h | 10 ++++
> 4 files changed, 122 insertions(+)
> create mode 100644 drivers/bluetooth/btandroid.c
> create mode 100644 drivers/bluetooth/btandroid.h
I am confused now. Did you read my review comments? I do _not_ want it this way; so please read my previous response and don’t send the exact same patch again.
Regards
Marcel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report
2021-09-13 14:32 ` Marcel Holtmann
@ 2021-09-26 7:14 ` Joseph Hwang
0 siblings, 0 replies; 7+ messages in thread
From: Joseph Hwang @ 2021-09-26 7:14 UTC (permalink / raw)
To: Marcel Holtmann
Cc: linux-bluetooth, Luiz Augusto von Dentz, Pali Rohár,
CrosBT Upstreaming, kernel test robot, Miao-chen Chou,
Johan Hedberg, linux-kernel
Hi Marcel:
I am very sorry that I missed your review comment! I have used
net/bluetooth/aosp.c to replace drivers/bluetooth/btandroid.c, and
enable the aosp capability by hci_set_aosp_capable() in the drivers.
The new patch subject is
[v4,1/4] Bluetooth: aosp: Support AOSP Bluetooth Quality Report
(https://patchwork.kernel.org/project/bluetooth/patch/20210926150657.v4.1.Iaa4a0269e51d8e8d8784a6ac8e05899b49a1377d@changeid/)
Please take a look.
Thanks and regards,
Joseph
On Mon, Sep 13, 2021 at 10:32 PM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Joseph,
>
> > Add the btandroid.c file to support Android BQR commands.
> >
> > This module may be referenced by btusb, btrtl, and hci_qca when a
> > Bluetooth controller supports the Android Bluetooth Quality Report.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> > Signed-off-by: Joseph Hwang <josephsih@chromium.org>
> > ---
> >
> > Changes in v3:
> > - Fix the auto build test ERROR
> > "undefined symbol: btandroid_set_quality_report" that occurred
> > with some kernel configs.
> > - Note that the mgmt-tester "Read Exp Feature - Success" failed.
> > But on my test device, the same test passed. Please kindly let me
> > know what may be going wrong. These patches do not actually
> > modify read/set experimental features.
> > - As to CheckPatch failed. No need to modify the MAINTAINERS file.
> > Thanks.
> >
> > Changes in v2:
> > - Fix the titles of patches 2/3 and 3/3 and reduce their lengths.
> >
> > drivers/bluetooth/Kconfig | 5 ++
> > drivers/bluetooth/Makefile | 1 +
> > drivers/bluetooth/btandroid.c | 106 ++++++++++++++++++++++++++++++++++
> > drivers/bluetooth/btandroid.h | 10 ++++
> > 4 files changed, 122 insertions(+)
> > create mode 100644 drivers/bluetooth/btandroid.c
> > create mode 100644 drivers/bluetooth/btandroid.h
>
> I am confused now. Did you read my review comments? I do _not_ want it this way; so please read my previous response and don’t send the exact same patch again.
>
> Regards
>
> Marcel
>
--
Joseph Shyh-In Hwang
Email: josephsih@google.com
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-09-26 7:15 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 7:28 [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report Joseph Hwang
2021-09-13 7:28 ` [PATCH v3 2/3] Bluetooth: hci_qca: Set up Qualcomm WCN399x for Android BQR commands Joseph Hwang
2021-09-13 7:28 ` [PATCH v3 3/3] Bluetooth: btrtl: Set up Realtek 8822CE " Joseph Hwang
2021-09-13 7:59 ` [v3,1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report bluez.test.bot
2021-09-13 9:55 ` [PATCH v3 1/3] " Pavel Machek
2021-09-13 14:32 ` Marcel Holtmann
2021-09-26 7:14 ` Joseph Hwang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).