From: Miao-chen Chou <mcchou@chromium.org>
To: Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>
Cc: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
Howard Chung <howardchung@google.com>,
Alain Michaud <alainm@chromium.org>,
Marcel Holtmann <marcel@holtmann.org>,
Miao-chen Chou <mcchou@chromium.org>
Subject: [BlueZ PATCH v7 0/4] Detailed error string
Date: Thu, 30 Sep 2021 15:37:22 -0700 [thread overview]
Message-ID: <20210930223726.2886139-1-mcchou@chromium.org> (raw)
Chromium OS has been working closely with Linux Bluetooth community to
improve BlueZ stack, and there are increasing needs from applications
building their features around Bluetooth. One of the major feedback
from these application is the lack of the detailed failure reasons as
return for D-Bus method call, and these failure reasons can be used in
metrics, optimizing retry mechanism, hinting the reproduce scenario to
improve BlueZ stack. The current org.bluez.Error.* are serving the
generic errors well. However,g given org.bluez.Error.* errors are used
across different interface context which does not serve the detailed
failure reasons well. (See https://github.com/bluez/bluez/issues/131)
Changes in v7:
- Fix nits
Changes in v6:
- Rephrase error string
Changes in v5:
- Replace error code with error string
Changes in v4:
- Address make errors.
Changes in v3:
- Correct error-codes.txt.
Changes in v2:
- Add documentation for error codes
Miao-chen Chou (4):
Add errors.txt to describe errors of D-Bus method returns
BR/EDR and LE connection failure reasons
Include detailed error string in Connect() return
Print error code for connect methods
client/main.c | 3 +-
doc/errors.txt | 233 +++++++++++++++++++++++++++++++++++++++++++++++++
src/device.c | 46 ++++++----
src/error.c | 100 +++++++++++++++++++++
src/error.h | 57 ++++++++++++
5 files changed, 422 insertions(+), 17 deletions(-)
create mode 100644 doc/errors.txt
--
2.33.0.800.g4c38ced690-goog
next reply other threads:[~2021-09-30 22:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 22:37 Miao-chen Chou [this message]
2021-09-30 22:37 ` [BlueZ PATCH v7 1/4] doc: Add errors.txt to describe errors of D-Bus method returns Miao-chen Chou
2021-09-30 22:37 ` [BlueZ PATCH v7 2/4] error: BR/EDR and LE connection failure reasons Miao-chen Chou
2021-09-30 22:37 ` [BlueZ PATCH v7 3/4] device: Include detailed error string in Connect() return Miao-chen Chou
2021-09-30 22:37 ` [BlueZ PATCH v7 4/4] client: Print error code for connect methods Miao-chen Chou
2021-10-04 22:48 ` [BlueZ PATCH v7 0/4] Detailed error string Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210930223726.2886139-1-mcchou@chromium.org \
--to=mcchou@chromium.org \
--cc=alainm@chromium.org \
--cc=howardchung@google.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).