linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manish Mandlik <mmandlik@google.com>
To: marcel@holtmann.org, luiz.dentz@gmail.com
Cc: linux-bluetooth@vger.kernel.org,
	chromeos-bluetooth-upstreaming@chromium.org,
	Manish Mandlik <mmandlik@google.com>,
	Archie Pusaka <apusaka@google.com>,
	Miao-chen Chou <mcchou@google.com>
Subject: [BlueZ PATCH v5 5/6] adv_monitor: Change sampling period to uint16_t
Date: Wed, 17 Nov 2021 11:14:49 -0800	[thread overview]
Message-ID: <20211117110627.BlueZ.v5.5.Ib85d2d946d853ea8c879dc922ad8e47587d3c603@changeid> (raw)
In-Reply-To: <20211117110627.BlueZ.v5.1.I7f6bdb9282c1e12ffc6c662674678f2b1cb69182@changeid>

In the Advertisement Monitor API, RSSISamplingPeriod is an unsigned
value. Change sampling_period variable to uint16_t in the code.

More info: doc/advertisement-monitor-api.txt

Reviewed-by: Archie Pusaka <apusaka@google.com>
Reviewed-by: Miao-chen Chou <mcchou@google.com>
---

Changes in v5:
- New patch in the series. Update 'sampling_period' data type to the
  correct type.

 src/adv_monitor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/adv_monitor.c b/src/adv_monitor.c
index 1a8397259..fbb5277dc 100644
--- a/src/adv_monitor.c
+++ b/src/adv_monitor.c
@@ -772,7 +772,7 @@ static bool parse_rssi_and_timeout(struct adv_monitor *monitor,
 	int16_t l_rssi = ADV_MONITOR_UNSET_RSSI;
 	uint16_t h_rssi_timeout = ADV_MONITOR_UNSET_TIMEOUT;
 	uint16_t l_rssi_timeout = ADV_MONITOR_UNSET_TIMEOUT;
-	int16_t sampling_period = ADV_MONITOR_UNSET_SAMPLING_PERIOD;
+	uint16_t sampling_period = ADV_MONITOR_UNSET_SAMPLING_PERIOD;
 	uint16_t adapter_id = monitor->app->manager->adapter_id;
 
 	/* Extract RSSIHighThreshold */
-- 
2.34.0.rc1.387.gb447b232ab-goog


  parent reply	other threads:[~2021-11-17 19:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 19:14 [BlueZ PATCH v5 1/6] doc: Introduce the Adv Monitor Device Found/Lost events Manish Mandlik
2021-11-17 19:14 ` [BlueZ PATCH v5 2/6] lib: Add definitions of " Manish Mandlik
2021-11-17 19:14 ` [BlueZ PATCH v5 3/6] adv_monitor: Receive the " Manish Mandlik
2021-11-17 21:42   ` Luiz Augusto von Dentz
2021-11-17 19:14 ` [BlueZ PATCH v5 4/6] adv_monitor: Invoke DeviceFound/Lost on tracked monitors Manish Mandlik
2021-11-17 19:14 ` Manish Mandlik [this message]
2021-11-17 19:14 ` [BlueZ PATCH v5 6/6] core: Update default advmon Sampling_Period to 0xFF Manish Mandlik
2021-11-17 21:09   ` Luiz Augusto von Dentz
     [not found]     ` <CAGPPCLB9KSDG1LFYeeKnPjtD001Q00PXgkRnh8Xz_9N=zB+mqg@mail.gmail.com>
2021-11-19 19:40       ` Luiz Augusto von Dentz
2021-11-17 19:32 ` [BlueZ,v5,1/6] doc: Introduce the Adv Monitor Device Found/Lost events bluez.test.bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211117110627.BlueZ.v5.5.Ib85d2d946d853ea8c879dc922ad8e47587d3c603@changeid \
    --to=mmandlik@google.com \
    --cc=apusaka@google.com \
    --cc=chromeos-bluetooth-upstreaming@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=mcchou@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).