* [PATCH v1] btusb: Avoid reset of ISOC endpoint alt settings to zero
@ 2022-10-03 6:48 Kiran K
2022-10-03 7:32 ` [v1] " bluez.test.bot
2022-10-07 19:40 ` [PATCH v1] " patchwork-bot+bluetooth
0 siblings, 2 replies; 4+ messages in thread
From: Kiran K @ 2022-10-03 6:48 UTC (permalink / raw)
To: linux-bluetooth; +Cc: ravishankar.srivatsa, Chethan Tumkur Narayan, Kiran K
From: Chethan Tumkur Narayan <chethan.tumkur.narayan@intel.com>
In case of suspend/resume and HCI_RESET (BT On and Off),
ISOC endpoint set to alt setting 0 when no SCO connection exists.
This patch shall avoid resetting of ISOC endpoint to alt setting to 0.
Signed-off-by: Chethan Tumkur Narayan <chethan.tumkur.narayan@intel.com>
Signed-off-by: Kiran K <kiran.k@intel.com>
---
drivers/bluetooth/btusb.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 271963805a38..ebfec6d8573f 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -1981,10 +1981,11 @@ static void btusb_work(struct work_struct *work)
if (btusb_switch_alt_setting(hdev, new_alts) < 0)
bt_dev_err(hdev, "set USB alt:(%d) failed!", new_alts);
} else {
- clear_bit(BTUSB_ISOC_RUNNING, &data->flags);
usb_kill_anchored_urbs(&data->isoc_anchor);
- __set_isoc_interface(hdev, 0);
+ if (test_and_clear_bit(BTUSB_ISOC_RUNNING, &data->flags))
+ __set_isoc_interface(hdev, 0);
+
if (test_and_clear_bit(BTUSB_DID_ISO_RESUME, &data->flags))
usb_autopm_put_interface(data->isoc ? data->isoc : data->intf);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [v1] btusb: Avoid reset of ISOC endpoint alt settings to zero
2022-10-03 6:48 [PATCH v1] btusb: Avoid reset of ISOC endpoint alt settings to zero Kiran K
@ 2022-10-03 7:32 ` bluez.test.bot
2022-10-04 18:43 ` Luiz Augusto von Dentz
2022-10-07 19:40 ` [PATCH v1] " patchwork-bot+bluetooth
1 sibling, 1 reply; 4+ messages in thread
From: bluez.test.bot @ 2022-10-03 7:32 UTC (permalink / raw)
To: linux-bluetooth, kiran.k
[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=682688
---Test result---
Test Summary:
CheckPatch PASS 1.79 seconds
GitLint PASS 1.02 seconds
SubjectPrefix FAIL 0.86 seconds
BuildKernel PASS 44.01 seconds
BuildKernel32 PASS 37.35 seconds
Incremental Build with patchesPASS 52.88 seconds
TestRunner: Setup PASS 611.23 seconds
TestRunner: l2cap-tester PASS 19.50 seconds
TestRunner: iso-tester PASS 19.65 seconds
TestRunner: bnep-tester PASS 7.79 seconds
TestRunner: mgmt-tester PASS 119.75 seconds
TestRunner: rfcomm-tester PASS 12.14 seconds
TestRunner: sco-tester PASS 11.26 seconds
TestRunner: ioctl-tester PASS 12.80 seconds
TestRunner: smp-tester PASS 11.21 seconds
TestRunner: userchan-tester PASS 7.94 seconds
Details
##############################
Test: SubjectPrefix - FAIL - 0.86 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [v1] btusb: Avoid reset of ISOC endpoint alt settings to zero
2022-10-03 7:32 ` [v1] " bluez.test.bot
@ 2022-10-04 18:43 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2022-10-04 18:43 UTC (permalink / raw)
To: linux-bluetooth; +Cc: kiran.k
Hi Kiran,
On Mon, Oct 3, 2022 at 1:27 AM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=682688
>
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 1.79 seconds
> GitLint PASS 1.02 seconds
> SubjectPrefix FAIL 0.86 seconds
> BuildKernel PASS 44.01 seconds
> BuildKernel32 PASS 37.35 seconds
> Incremental Build with patchesPASS 52.88 seconds
> TestRunner: Setup PASS 611.23 seconds
> TestRunner: l2cap-tester PASS 19.50 seconds
> TestRunner: iso-tester PASS 19.65 seconds
> TestRunner: bnep-tester PASS 7.79 seconds
> TestRunner: mgmt-tester PASS 119.75 seconds
> TestRunner: rfcomm-tester PASS 12.14 seconds
> TestRunner: sco-tester PASS 11.26 seconds
> TestRunner: ioctl-tester PASS 12.80 seconds
> TestRunner: smp-tester PASS 11.21 seconds
> TestRunner: userchan-tester PASS 7.94 seconds
>
> Details
> ##############################
> Test: SubjectPrefix - FAIL - 0.86 seconds
> Check subject contains "Bluetooth" prefix
> "Bluetooth: " is not specified in the subject
>
>
>
> ---
> Regards,
> Linux Bluetooth
Should we add a Fixes: tag? Also is there any bug that shall be listed as Link:?
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] btusb: Avoid reset of ISOC endpoint alt settings to zero
2022-10-03 6:48 [PATCH v1] btusb: Avoid reset of ISOC endpoint alt settings to zero Kiran K
2022-10-03 7:32 ` [v1] " bluez.test.bot
@ 2022-10-07 19:40 ` patchwork-bot+bluetooth
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+bluetooth @ 2022-10-07 19:40 UTC (permalink / raw)
To: Kiran K; +Cc: linux-bluetooth, ravishankar.srivatsa, chethan.tumkur.narayan
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Mon, 3 Oct 2022 12:18:36 +0530 you wrote:
> From: Chethan Tumkur Narayan <chethan.tumkur.narayan@intel.com>
>
> In case of suspend/resume and HCI_RESET (BT On and Off),
> ISOC endpoint set to alt setting 0 when no SCO connection exists.
> This patch shall avoid resetting of ISOC endpoint to alt setting to 0.
>
> Signed-off-by: Chethan Tumkur Narayan <chethan.tumkur.narayan@intel.com>
> Signed-off-by: Kiran K <kiran.k@intel.com>
>
> [...]
Here is the summary with links:
- [v1] btusb: Avoid reset of ISOC endpoint alt settings to zero
https://git.kernel.org/bluetooth/bluetooth-next/c/ed9fc1335a21
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-07 19:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-03 6:48 [PATCH v1] btusb: Avoid reset of ISOC endpoint alt settings to zero Kiran K
2022-10-03 7:32 ` [v1] " bluez.test.bot
2022-10-04 18:43 ` Luiz Augusto von Dentz
2022-10-07 19:40 ` [PATCH v1] " patchwork-bot+bluetooth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).