From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35BEAC4363A for ; Mon, 5 Oct 2020 12:19:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDA6320848 for ; Mon, 5 Oct 2020 12:19:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726431AbgJEMTg convert rfc822-to-8bit (ORCPT ); Mon, 5 Oct 2020 08:19:36 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:49734 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbgJEMTf (ORCPT ); Mon, 5 Oct 2020 08:19:35 -0400 Received: from marcel-macpro.fritz.box (p4fefc7f4.dip0.t-ipconnect.de [79.239.199.244]) by mail.holtmann.org (Postfix) with ESMTPSA id 6F7CECED23; Mon, 5 Oct 2020 14:26:33 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist" From: Marcel Holtmann In-Reply-To: <20201005083624.GA2442@kroah.com> Date: Mon, 5 Oct 2020 14:19:32 +0200 Cc: Johan Hedberg , Sathish Narsimman , "David S. Miller" , Jakub Kicinski , linux-bluetooth , "open list:NETWORKING [GENERAL]" , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <220D3B4E-D73E-43AD-8FF8-887D1A628235@holtmann.org> References: <20201003135449.GA2691@kroah.com> <20201003160713.GA1512229@kroah.com> <20201004105124.GA2429@kroah.com> <3F7BDD50-DEA3-4CB0-A9A0-69E7EE2923D5@holtmann.org> <20201005083624.GA2442@kroah.com> To: Greg Kroah-Hartman X-Mailer: Apple Mail (2.3608.120.23.2.1) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Greg, >>>>>>> This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it >>>>>>> breaks all bluetooth connections on my machine. >>>>>>> >>>>>>> Cc: Marcel Holtmann >>>>>>> Cc: Sathish Narsimman >>>>>>> Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist") >>>>>>> Signed-off-by: Greg Kroah-Hartman >>>>>>> --- >>>>>>> net/bluetooth/hci_request.c | 41 ++----------------------------------- >>>>>>> 1 file changed, 2 insertions(+), 39 deletions(-) >>>>>>> >>>>>>> This has been bugging me for since 5.9-rc1, when all bluetooth devices >>>>>>> stopped working on my desktop system. I finally got the time to do >>>>>>> bisection today, and it came down to this patch. Reverting it on top of >>>>>>> 5.9-rc7 restored bluetooth devices and now my input devices properly >>>>>>> work. >>>>>>> >>>>>>> As it's almost 5.9-final, any chance this can be merged now to fix the >>>>>>> issue? >>>>>> >>>>>> can you be specific what breaks since our guys and I also think the >>>>>> ChromeOS guys have been testing these series of patches heavily. >>>>> >>>>> My bluetooth trackball does not connect at all. With this reverted, it >>>>> all "just works". >>>>> >>>>> Same I think for a Bluetooth headset, can check that again if you really >>>>> need me to, but the trackball is reliable here. >>>>> >>>>>> When you run btmon does it indicate any errors? >>>>> >>>>> How do I run it and where are the errors displayed? >>>> >>>> you can do btmon -w trace.log and just let it run like tcdpump. >>> >>> Ok, attached. >>> >>> The device is not connecting, and then I open the gnome bluetooth dialog >>> and it scans for devices in the area, but does not connect to my >>> existing devices at all. >>> >>> Any ideas? >> >> the trace file is from -rc7 or from -rc7 with this patch reverted? >> >> I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch. >> >> diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c >> index e0269192f2e5..94c0daa9f28d 100644 >> --- a/net/bluetooth/hci_request.c >> +++ b/net/bluetooth/hci_request.c >> @@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req, >> return -1; >> >> /* White list can not be used with RPAs */ >> - if (!allow_rpa && !use_ll_privacy(hdev) && >> + if (!allow_rpa && >> hci_find_irk_by_addr(hdev, ¶ms->addr, params->addr_type)) { >> return -1; >> } >> @@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req) >> } >> >> /* White list can not be used with RPAs */ >> - if (!allow_rpa && !use_ll_privacy(hdev) && >> + if (!allow_rpa && >> hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) { >> return 0x00; >> } >> >> >> If you just do the above, does thing work for you again? > > Corrupted white-space issues aside, yes, it works! I just pasted it from a different terminal ;) > I am running 5.9-rc8 with just this change on it and my tracball works > just fine. > >> My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled. > > How would one go about enabling such a hardware feature if they wanted > to? :) I need to understand what is going wrong for you. I have a suspicion, but first I need to understand what kind of device you have. I hope the trace file is enough. > Anyway, feel free to put: > > Tested-by: Greg Kroah-Hartman > > on the above patch and hopefully get it to Linus for 5.9-final. Sadly, it is a poor hot-needle fix. Regards Marcel