From: Szymon Janc <szymon.janc@codecoup.pl>
To: Bastien Nocera <hadess@hadess.net>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] sixaxis: Fix another problem with already setup devices
Date: Thu, 13 Jun 2019 11:54:51 +0200 [thread overview]
Message-ID: <2507772.q0OjLXfh9R@ix> (raw)
In-Reply-To: <20190607065411.28502-1-hadess@hadess.net>
Hi Bastien,
On Friday, 7 June 2019 08:54:10 CEST Bastien Nocera wrote:
> If the device went through any kind of pairing once, it might have been
> set as trusted. Make sure to set the device as untrusted before starting
> the cable pairing authorization so that we don't exit early from
> process_auth_queue() (which considers trusted devices to be paired).
> ---
> plugins/sixaxis.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
> index fed68d2d8..12638829b 100644
> --- a/plugins/sixaxis.c
> +++ b/plugins/sixaxis.c
> @@ -365,6 +365,7 @@ static bool setup_device(int fd, const char *sysfs_path,
>
> btd_device_device_set_name(device, cp->name);
> btd_device_set_pnpid(device, cp->source, cp->vid, cp->pid, cp-
>version);
> + btd_device_set_trusted(device, false);
> btd_device_set_temporary(device, true);
>
> closure = g_new0(struct authentication_closure, 1);
Both patches applied, thanks.
--
pozdrawiam
Szymon Janc
prev parent reply other threads:[~2019-06-13 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 6:54 [PATCH 1/2] sixaxis: Fix another problem with already setup devices Bastien Nocera
2019-06-07 6:54 ` [PATCH 2/2] sixaxis: Throw an error when cable setup fails Bastien Nocera
2019-06-13 9:54 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2507772.q0OjLXfh9R@ix \
--to=szymon.janc@codecoup.pl \
--cc=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).