From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA43515B996 for ; Wed, 24 Apr 2024 14:25:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713968730; cv=none; b=BO60pPDmNPS6c3KGUWyrx+rqkwxK79V1AccshHVY/0uFmg0ITkbtxvOGL+/LhLEA9H/mQCm1PeqRnfEov/UOwVZQQm3VEhJWJJD1XRu+M4GCQisBZJ9OKwY4oiWGeaFj8ykXhjbLtrSBXUJ2wpOPC2Ho/im3cCGcuXdtBGVrKpY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713968730; c=relaxed/simple; bh=AKyfTfpOL+0RT3hrKuvytltOpsrdNFX9auR+VKtPbe4=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=YcecrID3xMzKaoIhEfInSdNryMbOoeDv+jhygdC+YRTUo/eN99oFcVPpTl4uh1aSgUguG+/nKqL4VTdbeZ6W5neeuZURX7jUuWqJQs1sryalR1FI1jq8VwmdjpH5cxAm+z6Uy2B2Qh+bMaLLCsLAJ3+R6i0g4lviybMNzjpc3Do= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=Ykfkbatu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Ykfkbatu" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 43ODpbWe007918; Wed, 24 Apr 2024 14:25:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=YOMMg1Ljiv/pSB3j/ObfRHGImFpRw8lpRljFGQEIA94=; b=Yk fkbatunaWXrk+4tMIyyxSzimfVQ4SMjXrdSJBNF4E/aOeZHtdJwpLVToGa+USdFB j8UUlJ8vRf5BPxwmMOj1gNE+lRy9g6LllJgaNuQOyYzLHqgcq5KOCdCL/plYYTwZ r6SzxWDXjZCcWSulJP5O7+x5O6oUp2rk6B8Y4HzNHbvCdBDKIWF8IgBU6d88UdoB sHeZX0FsJNq2elEVFPU1JtSCA01lP0hW9rOypUOnjcFj8RK7byYA4NLz1QIkunEI fWi+oSTFaSHppzATTrSakOmsQeUaJrG9LsYR25hBF5TgMohKDRJhZjHSNpMhfglu dIw+RTbyDHc7Voy2uzGg== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xpv9ph38s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Apr 2024 14:25:19 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 43OEPIMO020979 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Apr 2024 14:25:18 GMT Received: from [10.253.14.221] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 24 Apr 2024 07:25:12 -0700 Message-ID: <2805ad96-6383-45b3-9b68-66578461bb5f@quicinc.com> Date: Wed, 24 Apr 2024 22:25:10 +0800 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/2] Bluetooth: qca: Fix BT enable failure for QCA6390 To: Bartosz Golaszewski , "Luiz Augusto von Dentz" CC: Wren Turkal , Krzysztof Kozlowski , , , , , References: <1713919602-5812-1-git-send-email-quic_zijuhu@quicinc.com> <1713919602-5812-2-git-send-email-quic_zijuhu@quicinc.com> <349b27a5-d2d3-46f1-b002-44f81e0cedef@linaro.org> <8ae32009-5f5e-49a1-88a1-e330f0614f60@quicinc.com> <5e363318-c6e4-4874-8026-7940b434d583@linaro.org> <2020a858-c3d9-48a7-ad59-3691c6b98fb2@penguintechs.org> <38736db8-eec4-4ebd-b4c4-4b404cea6e42@quicinc.com> Content-Language: en-US From: quic_zijuhu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 73XuiRfE1QRwz2WfIdGxuAMRYiOf_uSg X-Proofpoint-ORIG-GUID: 73XuiRfE1QRwz2WfIdGxuAMRYiOf_uSg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-24_11,2024-04-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 spamscore=0 mlxscore=0 mlxlogscore=999 clxscore=1015 adultscore=0 malwarescore=0 bulkscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2404240052 On 4/24/2024 10:19 PM, Bartosz Golaszewski wrote: > On Wed, 24 Apr 2024 at 16:08, Luiz Augusto von Dentz > wrote: >> >> Hi Bartosz, >> >> On Wed, Apr 24, 2024 at 10:00 AM Bartosz Golaszewski >> wrote: >>> >>> On Wed, 24 Apr 2024 at 15:53, quic_zijuhu wrote: >>>> >>>>>>> >>>>>>> Please slow down here. Zijun's patch works and Bartosz's patch does not. >>>>>>> I don't think Zijun means any ill intent. I am replying to Bartosz's >>>>>>> patch right now. >>>>>> >>>>>> Ok, that is great feedback, so I might be picking up the Zijun v7 set >>>>>> if we don't find any major problems with it. >>>>>> >>>>> >>>>> Luiz, >>>>> >>>>> Please consider my alternative[1] also tested by Wren. Zijun's usage >>>>> of GPIO API is wrong. >>>>> >>>> why is it wrong ? >>>> >>> >>> I have already told you that at least three times. But whatever, let >>> me repeat again: gpiod_get_optional() returns NULL if the given GPIO >>> is not assigned to the device in question OR a pointer to a valid GPIO >>> descriptor. Anything else returned by it is an error and the driver >>> must abort probe(). >> >> Ok, but there are other fixes on top of it: >> >> https://patchwork.kernel.org/project/bluetooth/patch/1713932807-19619-3-git-send-email-quic_zijuhu@quicinc.com/ >> >> I guess that could go in but it would really help if you guys could >> work together so we don't have more competing solutions. >> > > These threads with their 7 patch versions from Zijun within 2 days or > so have become very chaotic. Let me summarize: there are two > regressions: one caused by my commit 6845667146a2 ("Bluetooth: > hci_qca: Fix NULL vs IS_ERR_OR_NULL check in qca_serdev_probe") and a > second caused by Krzysztof's commit 272970be3dab ("Bluetooth: hci_qca: > Fix driver shutdown on closed serdev"). The patch I linked here is how > I propose to fix my regression only. These fixes don't seem to > conflict with one another. > it is not conflict issue, from my perspective, you fix are wrong. do you see my patch change log? > We (Krzysztof and I) have provided feedback to Zijun but he refused to > address it and instead kept on resending his patches every couple > hours. Zijun's patch 1/2 proposed to revert my commit 6845667146a2. I > disagreed and proposed a way forward by fixing the regression. This > fix was incorrect as pointed out by Wren, so I submitted v2 which > works. > v2 is not right from my point as i commented with your solution. you don't answer my questions commented within your solution. what is your question i don't answer? > Bartosz