From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 963FDC31E40 for ; Mon, 12 Aug 2019 16:29:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74ECB20679 for ; Mon, 12 Aug 2019 16:29:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726993AbfHLQ3c (ORCPT ); Mon, 12 Aug 2019 12:29:32 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:52463 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbfHLQ3c (ORCPT ); Mon, 12 Aug 2019 12:29:32 -0400 Received: from marcel-macbook.fritz.box (p4FEFC580.dip0.t-ipconnect.de [79.239.197.128]) by mail.holtmann.org (Postfix) with ESMTPSA id 23EACCECF3; Mon, 12 Aug 2019 18:38:12 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH v5 19/29] compat_ioctl: move hci_sock handlers into driver From: Marcel Holtmann In-Reply-To: <20190730195819.901457-7-arnd@arndb.de> Date: Mon, 12 Aug 2019 18:29:30 +0200 Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hedberg , "David S. Miller" , Deepa Dinamani , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <29753EE8-74C4-4544-801B-3E7F3E4EEA60@holtmann.org> References: <20190730192552.4014288-1-arnd@arndb.de> <20190730195819.901457-1-arnd@arndb.de> <20190730195819.901457-7-arnd@arndb.de> To: Arnd Bergmann X-Mailer: Apple Mail (2.3445.104.11) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Arnd, > All these ioctl commands are compatible, so we can handle > them with a trivial wrapper in hci_sock.c and remove > the listing in fs/compat_ioctl.c. > > A few of the commands pass integer arguments instead of > pointers, so for correctness skip the compat_ptr() conversion > here. > > Signed-off-by: Arnd Bergmann > --- > fs/compat_ioctl.c | 24 ------------------------ > net/bluetooth/hci_sock.c | 21 ++++++++++++++++++++- > 2 files changed, 20 insertions(+), 25 deletions(-) I think it is best if this series is applied as a whole. So whoever takes it Acked-by: Marcel Holtmann Regards Marcel