linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* bluetooth: If unknown option in L2CAP Configuration Request is a hint, Bluetooth stack responds with "Command Reject" instead of "Configuration Response"
@ 2020-01-28 13:27 Konstantin Forostyan
  2020-01-29  3:56 ` Marcel Holtmann
  0 siblings, 1 reply; 5+ messages in thread
From: Konstantin Forostyan @ 2020-01-28 13:27 UTC (permalink / raw)
  To: linux-bluetooth

Hello community,

It seems that there's a bug in Bluetooth stack of 4.20 kernel. I
discovered it during Bluetooth qualification tests. L2CAP/COS/CFD/BV-
12-C [Unknown Option Response] test fails because instead of
"Configuration Response" with error code 0x0003 "unknown option" the
Bluetooth stack generates "Command Reject".

I think, this happens because the tester (Bluetooth SIG PTS) uses hints
as unknown options, and the Bluetooth stack has special handling for
hints. 

I made a small patch in order to overcome this problem. Please confirm,
that the patch is feasible. If not, please suggest how to fix the
"Command Reject" problem.

Thank you and best regards,
Konstantin

--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -3381,11 +3381,11 @@
 			break;
 
 		default:
-			if (hint)
-				break;
-
 			result = L2CAP_CONF_UNKNOWN;
-			*((u8 *) ptr++) = type;
+
+			if (!hint)
+			    *((u8 *) ptr++) = type;
+
 			break;
 		}
 	}



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-01-29 10:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-28 13:27 bluetooth: If unknown option in L2CAP Configuration Request is a hint, Bluetooth stack responds with "Command Reject" instead of "Configuration Response" Konstantin Forostyan
2020-01-29  3:56 ` Marcel Holtmann
2020-01-29  8:53   ` Konstantin Forostyan
2020-01-29  9:01     ` Marcel Holtmann
2020-01-29 10:52       ` Konstantin Forostyan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).