Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 10/10] Bluetooth: btusb: Detect if an ACL packet is in fact an ISO packet
Date: Tue, 14 Jan 2020 15:19:11 +0100
Message-ID: <36A77D9E-63AC-427A-919C-DBF448D4C94A@holtmann.org> (raw)
In-Reply-To: <20200111022216.30842-11-luiz.dentz@gmail.com>

Hi Luiz,

> Fix up the packet type if ISO packets are sent over the bulk endpoint.
> 
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
> drivers/bluetooth/btusb.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index ded0ba83bcce..4b5172c785ce 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -663,11 +663,21 @@ static int btusb_recv_bulk(struct btusb_data *data, void *buffer, int count)
> 		hci_skb_expect(skb) -= len;
> 
> 		if (skb->len == HCI_ACL_HDR_SIZE) {
> +			__u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
> 			__le16 dlen = hci_acl_hdr(skb)->dlen;
> +			__u8 type;
> 
> 			/* Complete ACL header */
> 			hci_skb_expect(skb) = __le16_to_cpu(dlen);
> 
> +			/* Detect if ISO packet has been sent over bulk */
> +			if (hci_conn_num(data->hdev, ISO_LINK)) {
> +				type = hci_conn_lookup_type(data->hdev,
> +							    hci_handle(handle));
> +				if (type == ISO_LINK)
> +					hci_skb_pkt_type(skb) = HCI_ISODATA_PKT;
> +			}
> +

lets scrap this patch as well.

Regards

Marcel


      reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-11  2:22 [PATCH v2 00/10] Bluetooth 5.2 initial support Luiz Augusto von Dentz
2020-01-11  2:22 ` [PATCH v2 01/10] Bluetooth: Add definitions for CIS connections Luiz Augusto von Dentz
2020-01-14 14:11   ` Marcel Holtmann
2020-01-11  2:22 ` [PATCH v2 02/10] Bluetooth: Add initial implementation of " Luiz Augusto von Dentz
2020-01-11 22:33   ` kbuild test robot
2020-01-11  2:22 ` [PATCH v2 03/10] Bluetooth: L2CAP: Add definitions for Enhanced Credit Based Mode Luiz Augusto von Dentz
2020-01-14 14:15   ` Marcel Holtmann
2020-01-11  2:22 ` [PATCH v2 04/10] Bluetooth: L2CAP: Add initial code " Luiz Augusto von Dentz
2020-01-11  2:22 ` [PATCH v2 05/10] Bluetooth: hci_vhci: Add support for ISO packets Luiz Augusto von Dentz
2020-01-11  2:22 ` [PATCH v2 06/10] Bluetooth: monitor: " Luiz Augusto von Dentz
2020-01-11  2:22 ` [PATCH v2 07/10] Bluetooth: Make use of __check_timeout on hci_sched_le Luiz Augusto von Dentz
2020-01-11  2:22 ` [PATCH v2 08/10] Bluetooth: hci_h4: Add support for ISO packets Luiz Augusto von Dentz
2020-01-11  2:22 ` [PATCH v2 09/10] Bluetooth: btusb: " Luiz Augusto von Dentz
2020-01-14 14:18   ` Marcel Holtmann
2020-01-11  2:22 ` [PATCH v2 10/10] Bluetooth: btusb: Detect if an ACL packet is in fact an ISO packet Luiz Augusto von Dentz
2020-01-14 14:19   ` Marcel Holtmann [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36A77D9E-63AC-427A-919C-DBF448D4C94A@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git